Create account / Log in

VASSAL 3.1.0-beta4 released

Topics related to the main Vassal engine.

Moderators: uckelman, Tim M

VASSAL 3.1.0-beta4 released

Postby uckelman » October 31st, 2008, 9:30 am

Thus spake "Brent Easton":
Joel,

swampwallaby-work@4370 has a fix for:

Bug [2175571] NoSuchElementException in ColorConfigurer.stringToColor()

Colorconfigurer does not cope with corrupted input at all. There was FIXME th
ere as to whether it should actually throw an error. I don't think ColorConfi
gurer.stringToColor() should, but should return a valid color with the offend
ing components set to 0 (ie black if it is total junk).

Shouldn't it also send a BadDataReport to the log?

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8621
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 31st, 2008, 10:47 am

Colorconfigurer does not cope with corrupted input at all. There was
FIXME th
ere as to whether it should actually throw an error. I don't think
ColorConfi
gurer.stringToColor() should, but should return a valid color with the
offend
ing components set to 0 (ie black if it is total junk).

Shouldn't it also send a BadDataReport to the log?

Perhaps, you'll have to put the old code back.

B.


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby Tim M » October 31st, 2008, 1:05 pm

Tim, I solved this while playing with Combat Commander and also looked at
the 'Bad Data' errors for '$Allied Orders$' you get when you first start a
new game. This turned out to be problem at your end. The Setup Stacks Allies
OR and Axis OR have pieces that defined a numeric Dynamic Property with an
initial value of $Allied Orders$ or $Axis Orders$. These need to be numbers.


Ahh! Found it! Don't know how it changed though
Still getting the Bad Data error but it is not telling me where anymore.
I have narrowed it to two areas - The forementioned Palette Piece / DP
discussion upon opening palette in game or the use of CP's as it always
seems to pop up when I edit protos that are reliant on DP's / CP's in editor


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
Tim,
Vassal Uber Geek/Guru

Problems? post your OS, Physical Mem, version of Vassal and Java plus the Module in question.
No developer can help with out that info, thx!
User avatar
Tim M
 
Posts: 1803
Joined: December 8th, 2007, 12:22 pm
Location: Earth

VASSAL 3.1.0-beta4 released

Postby uckelman » October 31st, 2008, 10:32 pm

Thus spake "Brent Easton":
Joel,

swampwallaby-work@4369 has a fix for

RFE [2193791] Pieces in palette to show correct dynamic property values

It turned out to be a fairly easy fix and should not affect performance. Piec
eSlot now returns a fully expanded piece when asked one instead of an unexpan
ded one. This fixes teh display DP values in the palette where the DP is defi
ned in a prototype. It also fixes 'Bad Data in Module' errors when you first
open the piece palette.

Merged to trunk@4371.

Joel, Michael, Rodney, I did a test implementation of some of the PropertyPro
vider caching we discussed offline, but it had little measurable effect on my
testbed (Combat Commander). I implemented it for SELECTED, SNAPSHOT and PIEC
E_ID. Since it had so little effect, I hesitate to add it to beta 5 as there
may be unintended consequences. I think someone needs to review this whole ar
ea in more detail for 3.2. There are a whole bunch of gotcha's just waiting t
o jump out.

I think these fixes are probably fine as far as they go, but I'd be in favor
of rethinking the design for 3.2 instead.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8621
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby uckelman » October 31st, 2008, 10:48 pm

Thus spake "Brent Easton":
swampwallaby-work@4366 has some cosmetic fixes to the properties package. Mis
sing licence text, Id lines and some raw Class fixups.

B.

Merged to trunk@4372.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8621
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby Brent Easton » November 5th, 2008, 6:08 am

swampwallaby-work@4380 contains a fix for:

Bug [2176550] NumberFormatException in PositionOption.setValue()

It is a rare bug that can result from a naming conflict. I have changed the bug reporting to detect the naming conflict and report a BadDataReport with a suitable message, instead of a bug report.

B.



_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby uckelman » November 5th, 2008, 6:37 pm

Thus spake "Brent Easton":
swampwallaby-work@4380 contains a fix for:

Bug [2176550] NumberFormatException in PositionOption.setValue()

It is a rare bug that can result from a naming conflict. I have changed the b
ug reporting to detect the naming conflict and report a BadDataReport with a
suitable message, instead of a bug report.

B.


Merged to trunk@4381.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8621
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby Brent Easton » November 5th, 2008, 9:01 pm

Joel,

Still outstanding to be merged is swampwallaby-work@4360

Bug [2202296 ] Hang when moving trait up

B.



*********** REPLY SEPARATOR ***********

On 5/11/2008 at 7:37 PM Joel Uckelman wrote:

Thus spake "Brent Easton":
swampwallaby-work@4380 contains a fix for:

Bug [2176550] NumberFormatException in PositionOption.setValue()

It is a rare bug that can result from a naming conflict. I have changed
the b
ug reporting to detect the naming conflict and report a BadDataReport
with a
suitable message, instead of a bug report.

B.


Merged to trunk@4381.



_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby uckelman » November 5th, 2008, 9:09 pm

Thus spake "Brent Easton":
Joel,

Still outstanding to be merged is swampwallaby-work@4360

Bug [2202296 ] Hang when moving trait up


I'll get that now. I got tied up in following the election yesterday, in
addition to having had an awful cold almost the whole time since I returned
Australia. I feel like I'm flipped to my reduced side right now.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8621
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby uckelman » November 5th, 2008, 9:34 pm

Thus spake "Brent Easton":
Joel,

Still outstanding to be merged is swampwallaby-work@4360

Bug [2202296 ] Hang when moving trait up

B.

Merged to trunk@4388.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8621
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Previous

Return to General Discussion

Who is online

Users browsing this forum: No registered users and 5 guests