Create account / Log in

VASSAL 3.1.0-beta4 released

Topics related to the main Vassal engine.

Moderators: uckelman, Tim M

VASSAL 3.1.0-beta4 released

Postby uckelman » October 25th, 2008, 1:01 pm

Thus spake "Brent Easton":
Bug 2189633 NPE in Footprint.redraw() fixed in swampwallaby-work@4320.

Most methods in Footprint check for getMap() != null except for redraw().

B.

Merged to trunk@4321.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8623
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 27th, 2008, 6:27 am

Joel,

svn 4347 does not compile under Java 1.5

swampwallaby-work@4350 fixes two extraneous @override tags.

Not sure how to fix the last one - Board.java:398

g2d.setComposite(AlphaComposite.SrcOver.derive(a));

AlphaComposite.derive(float a) does not exist in 1.5.

B.




_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby uckelman » October 27th, 2008, 10:48 am

Thus spake "Brent Easton":
Joel,

svn 4347 does not compile under Java 1.5

swampwallaby-work@4350 fixes two extraneous @override tags.

Merged to trunk@4351.

Not sure how to fix the last one - Board.java:398

g2d.setComposite(AlphaComposite.SrcOver.derive(a));

AlphaComposite.derive(float a) does not exist in 1.5.

For our purposes, it's equivalent to AlphaComposite.getInstance(int,float).

Fixed in trunk@4352.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8623
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 28th, 2008, 1:16 am

Bug [2198485] NPE in PlaceMarker.updateGpId() fixed in swampwallaby-work@4356

B.


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 28th, 2008, 6:05 am

Joel,

Bug [2198485] NPE in PlaceMarker.updateGpId() fixed in
swampwallaby-work@4356

I got the bug Id's confused. This commit actually fixes

Bug [2194826] ArithmeticException in HexGrid.HexGridEditor.check()

B.



_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 28th, 2008, 6:20 am

Joel,

swampwallaby@4357 has the fix for

Bug [2172904] NPE in StackMetrics.merge()

Michael, this is one of yours, but I was checking a duplicate and had a quick look and realised what the problem was. It's part of some new code that went in, but it did not take into account that it is possible to have single counters on a board that do not belong to a Stack and do not have a parent.

B.


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby mkiefte » October 28th, 2008, 10:19 am

Thanks Brent,

I couldn't reproduce it at all, but that's okay, because in the process of trying to reproduce the bug, I found a completely unrelated one.

Did you make the fix? Can I change the status of the bug?

- M.

2008/10/28 Brent Easton <b.easton@exemail.com.au (b.easton@exemail.com.au)>
Joel,

swampwallaby@4357 has the fix for

Bug [2172904] NPE in StackMetrics.merge()

Michael, this is one of yours, but I was checking a duplicate and had a quick look and realised what the problem was. It's part of some new code that went in, but it did not take into account that it is possible to have single counters on a board that do not belong to a Stack and do not have a parent.


B.


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org (Messages@forums.vassalengine.org)
http://forums.vassalengine.org/mailman/listinfo/messages_forums.vassalengine.org





--
Michael Kiefte, Ph.D.
Associate Professor
School of Human Communication Disorders
Dalhousie University
Halifax, Nova Scotia, Canada
tel: +1 902 494 5150
fax: +1 902 494 5151

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
mkiefte
 
Posts: 1144
Joined: January 5th, 2008, 1:29 am
Location: Halifax, Nova Scotia, Canada

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 28th, 2008, 11:35 am

Did you make the fix? Can I change the status of the bug?

I have fixed it in my branch. I usually leave the bug Open until Joel merges the changes into the trunk.

B.



_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby uckelman » October 29th, 2008, 3:44 pm

Thus spake "Brent Easton":
Joel,

Bug [2198485] NPE in PlaceMarker.updateGpId() fixed in
swampwallaby-work@4356

I got the bug Id's confused. This commit actually fixes

Bug [2194826] ArithmeticException in HexGrid.HexGridEditor.check()

B.

Merged to trunk@4361.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8623
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby uckelman » October 30th, 2008, 2:09 pm

Thus spake "Brent Easton":
Joel,

swampwallaby@4357 has the fix for

Bug [2172904] NPE in StackMetrics.merge()

Michael, this is one of yours, but I was checking a duplicate and had a quick
look and realised what the problem was. It's part of some new code that went
in, but it did not take into account that it is possible to have single coun
ters on a board that do not belong to a Stack and do not have a parent.

B.

Merged to trunk.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8623
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 30th, 2008, 10:27 pm

swampwallaby-work@4366 has some cosmetic fixes to the properties package. Missing licence text, Id lines and some raw Class fixups.

B.


____________________________________________________________
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 31st, 2008, 4:18 am

Joel,

swampwallaby-work@4369 has a fix for

RFE [2193791] Pieces in palette to show correct dynamic property values

It turned out to be a fairly easy fix and should not affect performance. PieceSlot now returns a fully expanded piece when asked one instead of an unexpanded one. This fixes teh display DP values in the palette where the DP is defined in a prototype. It also fixes 'Bad Data in Module' errors when you first open the piece palette.

Tim, I solved this while playing with Combat Commander and also looked at the 'Bad Data' errors for '$Allied Orders$' you get when you first start a new game. This turned out to be problem at your end. The Setup Stacks Allies OR and Axis OR have pieces that defined a numeric Dynamic Property with an initial value of $Allied Orders$ or $Axis Orders$. These need to be numbers.

Joel, Michael, Rodney, I did a test implementation of some of the PropertyProvider caching we discussed offline, but it had little measurable effect on my testbed (Combat Commander). I implemented it for SELECTED, SNAPSHOT and PIECE_ID. Since it had so little effect, I hesitate to add it to beta 5 as there may be unintended consequences. I think someone needs to review this whole area in more detail for 3.2. There are a whole bunch of gotcha's just waiting to jump out.

The fixes already in solve the 2 major issues that was affecting the Stategos module.

B.


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 31st, 2008, 4:29 am

Starting to get a lot of duplicate bugs coming through the Bug Tracker from people still using beta 3.

B.

____________________________________________________________
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby Brent Easton » October 31st, 2008, 5:47 am

Joel,

swampwallaby-work@4370 has a fix for:

Bug [2175571] NoSuchElementException in ColorConfigurer.stringToColor()

Colorconfigurer does not cope with corrupted input at all. There was FIXME there as to whether it should actually throw an error. I don't think ColorConfigurer.stringToColor() should, but should return a valid color with the offending components set to 0 (ie black if it is total junk).

This bug looks to be due to a corrupted preference. If there is still a problem in the saving of the preference (which I can't see), then users will report some Color preference not 'sticking'.

B.


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2991
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

VASSAL 3.1.0-beta4 released

Postby uckelman » October 31st, 2008, 9:25 am

Thus spake "Brent Easton":
Starting to get a lot of duplicate bugs coming through the Bug Tracker from p
eople still using beta 3.

B.


I know, but we can't do anything about it. Beta3 reports directly to SF,
and has no update notifier. That won't happen with beta4, since we can
shut off bug reporting and it will pester people who are using it once
beta5 is released.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8623
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

PreviousNext

Return to General Discussion

Who is online

Users browsing this forum: No registered users and 2 guests