Mass Piece Loader issues with Layer trait

[barbanera]

There is something wrong with the Mass Piece Loader with Vassal 3.4.12 and Vassal 3.5.0-beta2. This issue was NOT present in Vassal 3.4.11.

I started a brand new module and then

1) added a deck to the main map,
2) selected "Add Multiple Cards"
3) selected "Edit Piece Template"
4) added a "Layer" trait

with Vassal 3.4.11 all is well and I get the "modified layer" trait,

with Vassal 3.4.12 I get a "Uncaught Exception" error message,

with Vassal 3.5.0-beta2 the normal "Layer" trait appears, instead of the "modified layer" trait.

[Brent Easton]

Thanks for the report, investigating. Strangely, the bugs in each revision are not related!

[uckelman]

What you saw in 3.4.12 is Bug 13861, which is fixed in VASSAL-3.4.13-SNAPSHOT-b52f6204f or any later build, available here:

http://www.vassalengine.org/~uckelman/tmp/

The bug in 3.5.0-beta2 is still outstanding.

[HelderDaniel]

Hi,

It seems that the layer selection of files is excluding the files that should be selected.

At least the way I am reading the help on:

file:///home/hdaniel/Apps/Vassal/VASSAL-3.4.12/doc/ReferenceManual/MassPieceLoader.htm

If we try the example there, for a folder with files:

unit1.png
unit1-trn.png
unit2.png
unit2-trn.png

selecting image name: "ends with" -trn

it loads images:

unit1.png
unit2.png

but i think it should select and load

unit1-trn.png
unit2-trn.png

Tryied with UBUNTU 20.04, with the versions:

VASSAL-3.4.13-SNAPSHOT-b6b5df8fe
3.4.12
and
3.4.11

all of them have the same behaviour

[HelderDaniel]

Hi,

For what i could understand in versions 3.4.11, 3.4.11 , 3.4.11 the conditions in layers to include files is actually excluding them.

[uckelman]

Thus spake HelderDaniel:
> Hi,
>
> It seems that the layer selection of files is excluding the files that
> should be selected.
>
> At least the way I am reading the help on:
>
> file:///home/hdaniel/Apps/Vassal/VASSAL-3.4.12/doc/ReferenceManual/MassPieceLoader.htm
>
> If we try the example there, for a folder with files:
>
> unit1.png
> unit1-trn.png
> unit2.png
> unit2-trn.png
>
> selecting image name: "ends with" -trn
>
> it loads images:
>
> unit1.png
> unit2.png
>
> but i think it should select and load
>
> unit1-trn.png
> unit2-trn.png

When you select "ends with" and set a pattern, that pattern will be matched
against image filenames which extend the basename of the image in that
way.

So, if you have one layer set to "ends with" and the pattern "-trn", what
you'll get are two pieces:

* one piece will have unit1.png as the base image and unit1-trn.png as
the layer.

* one piece will have unit2.png as the base image and unit2-trn.png as
the layer.

--
J.