Create account / Log in

Mass Piece Loader issues with Layer trait

Issues with the Vassal engine.

Moderators: uckelman, Tim M

Mass Piece Loader issues with Layer trait

Postby barbanera » January 14th, 2021, 6:37 pm

There is something wrong with the Mass Piece Loader with Vassal 3.4.12 and Vassal 3.5.0-beta2. This issue was NOT present in Vassal 3.4.11.

I started a brand new module and then

1) added a deck to the main map,
2) selected "Add Multiple Cards"
3) selected "Edit Piece Template"
4) added a "Layer" trait

with Vassal 3.4.11 all is well and I get the "modified layer" trait,

with Vassal 3.4.12 I get a "Uncaught Exception" error message,

with Vassal 3.5.0-beta2 the normal "Layer" trait appears, instead of the "modified layer" trait.
barbanera
 
Posts: 467
Joined: January 12th, 2012, 2:27 pm

Re: Mass Piece Loader issues with Layer trait

Postby Brent Easton » January 14th, 2021, 9:05 pm

Thanks for the report, investigating. Strangely, the bugs in each revision are not related!
User avatar
Brent Easton
 
Posts: 3310
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: Mass Piece Loader issues with Layer trait

Postby uckelman » January 18th, 2021, 12:07 am

What you saw in 3.4.12 is Bug 13861, which is fixed in VASSAL-3.4.13-SNAPSHOT-b52f6204f or any later build, available here:

http://www.vassalengine.org/~uckelman/tmp/

The bug in 3.5.0-beta2 is still outstanding.
User avatar
uckelman
Site Admin
 
Posts: 9227
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Mass Piece Loader issues with Layer trait

Postby HelderDaniel » January 21st, 2021, 2:07 am

Hi,

It seems that the layer selection of files is excluding the files that should be selected.

At least the way I am reading the help on:

file:///home/hdaniel/Apps/Vassal/VASSAL-3.4.12/doc/ReferenceManual/MassPieceLoader.htm

If we try the example there, for a folder with files:

unit1.png
unit1-trn.png
unit2.png
unit2-trn.png

selecting image name: "ends with" -trn

it loads images:

unit1.png
unit2.png

but i think it should select and load

unit1-trn.png
unit2-trn.png

Tryied with UBUNTU 20.04, with the versions:

VASSAL-3.4.13-SNAPSHOT-b6b5df8fe
3.4.12
and
3.4.11

all of them have the same behaviour
HelderDaniel
 
Posts: 2
Joined: December 6th, 2020, 4:25 pm

Re: Mass Piece Loader issues with Layer trait

Postby HelderDaniel » January 21st, 2021, 2:02 pm

Hi,

For what i could understand in versions 3.4.11, 3.4.11 , 3.4.11 the conditions in layers to include files is actually excluding them.
HelderDaniel
 
Posts: 2
Joined: December 6th, 2020, 4:25 pm

Re: Mass Piece Loader issues with Layer trait

Postby uckelman » January 22nd, 2021, 8:35 pm

Thus spake HelderDaniel:
> Hi,
>
> It seems that the layer selection of files is excluding the files that
> should be selected.
>
> At least the way I am reading the help on:
>
> file:///home/hdaniel/Apps/Vassal/VASSAL-3.4.12/doc/ReferenceManual/MassPieceLoader.htm
>
> If we try the example there, for a folder with files:
>
> unit1.png
> unit1-trn.png
> unit2.png
> unit2-trn.png
>
> selecting image name: "ends with" -trn
>
> it loads images:
>
> unit1.png
> unit2.png
>
> but i think it should select and load
>
> unit1-trn.png
> unit2-trn.png

When you select "ends with" and set a pattern, that pattern will be matched
against image filenames which extend the basename of the image in that
way.

So, if you have one layer set to "ends with" and the pattern "-trn", what
you'll get are two pieces:

* one piece will have unit1.png as the base image and unit1-trn.png as
the layer.

* one piece will have unit2.png as the base image and unit2-trn.png as
the layer.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 9227
Joined: December 10th, 2007, 9:48 am
Location: Durham, England


Return to Technical Support & Bugs

Who is online

Users browsing this forum: Klaus-Dieter and 3 guests