Create account / Log in

Couldn't save module {0} - Bug:1860932

Issues with the Vassal engine.

Moderators: Tim M, uckelman

Postby JMOxx75 » December 25th, 2007, 10:58 pm

Is this an issue with any other versions of Vassal? Does anyone know if this is getting looked at to be fixed?
JMOxx75
 
Posts: 34
Joined: December 20th, 2007, 7:54 pm

Postby MiGlo » December 26th, 2007, 12:01 am

I had same problem several times but I don't know what is a reason. Only way to help that I know is to save after every modification and to keep several versions of modules.
"I got an idea, an idea so smart my head would explode if I even began to know what I was talking about."
Peter Griffin
User avatar
MiGlo
 
Posts: 13
Joined: December 21st, 2007, 4:04 pm

Postby JMOxx75 » December 26th, 2007, 6:55 pm

It just seems that the bigger my mod gets the more it happens. It gets frustrating when I have to save every 5 seconds and I have like 15 saves of the same thing.
JMOxx75
 
Posts: 34
Joined: December 20th, 2007, 7:54 pm

Postby bsmith » December 26th, 2007, 8:35 pm

I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I'm on Windows Vista myself.

Confirmed again yesterday that sometimes not even "Save As" works to fix this error; In these cases the only resolution is to hope and pray that a temp.zip file still exists!
User avatar
bsmith
Site Admin
 
Posts: 657
Joined: October 2nd, 2007, 4:47 pm

Couldn't save module {0}

Postby uckelman » December 26th, 2007, 11:33 pm

Thus spake "bsmith":
I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I'm on Windows Vi
sta myself.

Confirmed again yesterday that sometimes not even "Save As" works to fix this
error; In these cases the only resolution is to hope and pray that a temp.z
ip file still exists!


This is a difficult bug for me to troubleshoot, because it doesn't occur
on my development box (Linux).

The first IOException in your errorLog probably happened because there
was an open file handle on the module file already. I've found many
places where we neglect to close streams, so this could be the result of
an unreferenced stream which was open on the module but not yet garbage
collected.

The second one could only happen if the module file no longer exists,
and I'm guessing that's a consequence of the first exception.

In order for me to investigate this problem, I *need* more errorLogs
from people who have experienced this bug, and if possible, a reliable
way to trigger it.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8373
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Couldn't save module {0}

Postby Brent Easton » December 26th, 2007, 11:43 pm

I'm getting this all the time on XP.

For me, it seems to be related to adding new counter images into the module via the File Dialog. General editing does not cause me any problems.

Regards,
Brent.

*********** REPLY SEPARATOR ***********

On 26/12/2007 at 12:35 PM bsmith wrote:

I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I'm on Windows
Vista myself.

Confirmed again yesterday that sometimes not even "Save As" works to fix
this error; In these cases the only resolution is to hope and pray that a
temp.zip file still exists!







_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org


--
No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.5.516 / Virus Database: 269.17.9/1198 - Release Date: 26/12/2007 5:26 PM


____________________________________________________________
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2863
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Couldn't save module {0}

Postby tbyrne » December 26th, 2007, 11:45 pm

EVERY time I've ever seen this (and there have been a number) I have
found other instances of VASSAL running. Those instances were no
longer visible, but they were running. I think it would be useful if
when experiencing this problem, the process list gets checked to see
if there are other java instances running.

It could be less of a problem with writing the file, and more of a
problem with VASSAL completely closing. Just a suggestion based on my
experience.

On 12/26/07, Joel Uckelman <uckelman@nomic.net> wrote:
Thus spake "bsmith":
I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I'm on Windows Vi
sta myself.

Confirmed again yesterday that sometimes not even "Save As" works to fix this
error; In these cases the only resolution is to hope and pray that a temp.z
ip file still exists!


This is a difficult bug for me to troubleshoot, because it doesn't occur
on my development box (Linux).

The first IOException in your errorLog probably happened because there
was an open file handle on the module file already. I've found many
places where we neglect to close streams, so this could be the result of
an unreferenced stream which was open on the module but not yet garbage
collected.

The second one could only happen if the module file no longer exists,
and I'm guessing that's a consequence of the first exception.

In order for me to investigate this problem, I *need* more errorLogs
from people who have experienced this bug, and if possible, a reliable
way to trigger it.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
tbyrne
 
Posts: 79
Joined: December 10th, 2007, 1:57 pm
Location: Chicago, IL

Couldn't save module {0}

Postby Brent Easton » December 27th, 2007, 12:55 am

Grab a copy of procexp.exe from

http://technet.microsoft.com/en-us/sysi ... 96653.aspx

It is Task Manager on steroids and can tell you what process has a file open.

Regards,
Brent.

*********** REPLY SEPARATOR ***********

On 26/12/2007 at 5:45 PM Tim Byrne wrote:

EVERY time I've ever seen this (and there have been a number) I have
found other instances of VASSAL running. Those instances were no
longer visible, but they were running. I think it would be useful if
when experiencing this problem, the process list gets checked to see
if there are other java instances running.

It could be less of a problem with writing the file, and more of a
problem with VASSAL completely closing. Just a suggestion based on my
experience.

On 12/26/07, Joel Uckelman <uckelman@nomic.net> wrote:
Thus spake "bsmith":
I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I'm on
Windows Vi
sta myself.

Confirmed again yesterday that sometimes not even "Save As" works to
fix this
error; In these cases the only resolution is to hope and pray that a
temp.z
ip file still exists!


This is a difficult bug for me to troubleshoot, because it doesn't occur
on my development box (Linux).

The first IOException in your errorLog probably happened because there
was an open file handle on the module file already. I've found many
places where we neglect to close streams, so this could be the result of
an unreferenced stream which was open on the module but not yet garbage
collected.

The second one could only happen if the module file no longer exists,
and I'm guessing that's a consequence of the first exception.

In order for me to investigate this problem, I *need* more errorLogs
from people who have experienced this bug, and if possible, a reliable
way to trigger it.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org

http://forums.vassalengine.org/mailman/listinfo/messages_forums.vassalengine.org

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org


--
No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.5.516 / Virus Database: 269.17.9/1198 - Release Date: 26/12/2007 5:26 PM


____________________________________________________________
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2863
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Couldn't save module {0}

Postby tbyrne » December 27th, 2007, 1:03 am

Good call, That's what I use. And every time, its been another java
process (specifically VASSAL) that has the file open.

On 12/26/07, Brent Easton <b.easton@exemail.com.au> wrote:
Grab a copy of procexp.exe from

http://technet.microsoft.com/en-us/sysi ... 96653.aspx

It is Task Manager on steroids and can tell you what process has a file open.

Regards,
Brent.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
tbyrne
 
Posts: 79
Joined: December 10th, 2007, 1:57 pm
Location: Chicago, IL

Postby bsmith » December 27th, 2007, 2:30 am

Nice! I'm adding that to my list of must-have Windows tools, right up alongside Spacemonger and PowerGrep :)
User avatar
bsmith
Site Admin
 
Posts: 657
Joined: October 2nd, 2007, 4:47 pm

Couldn't save module {0}

Postby uckelman » December 27th, 2007, 10:59 am

Thus spake "Tim Byrne":
EVERY time I've ever seen this (and there have been a number) I have
found other instances of VASSAL running. Those instances were no
longer visible, but they were running. I think it would be useful if
when experiencing this problem, the process list gets checked to see
if there are other java instances running.

It could be less of a problem with writing the file, and more of a
problem with VASSAL completely closing. Just a suggestion based on my
experience.

Why did you keep opening and closing VASSAL to work on the same file?

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8373
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Couldn't save module {0}

Postby bsmith » December 27th, 2007, 11:17 am

uckelman wrote:Why did you keep opening and closing VASSAL to work on the same file?


This is something I do a heck of a lot too. Quite often I like to make bulk changes to counter graphics, this may involve running a Photoshop Batch against 100 counters to clean them up/center images etc. So first I extract the module, modify the counters, re-zip the module then open it in Vassal to see how it all looks. After making some changes to the actual module, later on if I need to do more counter changes I need to repeat this process.

Another reason for opening and closing is I have VB scripts which do such things as import counters by parsing the buildFile (this is a Godsend!!), a script which takes counter names from a textfile and automatically names all of the counters in the module and sorts them alphabetically. These scripts mean I can churn out modules with hundreds of scanned counters in a couple of days. But it does involve lots of uncompressing and re-compressing of the module!

Hmmm, if only there was a way to open a module *folder* instead of a zip file.

Ben
User avatar
bsmith
Site Admin
 
Posts: 657
Joined: October 2nd, 2007, 4:47 pm

Possible fix for this bug

Postby uckelman » December 27th, 2007, 3:33 pm

I tracked down and fixed a lot of unclosed streams today. I think it's
possible that you won't see this bug in this build:

http://www.nomic.net/~uckelman/tmp/vassal/VASSAL-3.1.0-svn2766.zip

Please try it and let me know.
User avatar
uckelman
Site Admin
 
Posts: 8373
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Couldn't save module {0}

Postby tbyrne » December 27th, 2007, 3:44 pm

I only do about 1/3 of my editing in Vassal. The other 1/3 is in vi.
The other 1/3 is using perl.

The buildfile is not only XML, as you know its XML plus a bunch of
secret sauce. I often test my changes right away to make sure I'm ok
the right track.

I keep my source in SVN. So when I add images, I add them to SVN, and
rebuild the module (the build module is pretty much the only think I
don't keep on SVN). After making a bunch of changes in vassal I
extract the changes and often do a svndiff to better understand how
vassal does what I want under the hood.

Lastly, I have found instances when certain changes in the editor do
not take place until I restart vassal (not just the game) Of course
I've done a poor job of keeping track of that, so there are time when
I can't get things working as I like and I just restart hoping its one
of those changes. Sometime it is.

On Dec 27, 2007, at 5:17 AM, "bsmith"
<messages@forums.vassalengine.org> wrote:

uckelman wrote:
Why did you keep opening and closing VASSAL to work on the same file?



This is something I do a heck of a lot too. Quite often I like to
make bulk changes to counter graphics, this may involve running a
Photoshop Batch against 100 counters to clean them up/center images
etc. So first I extract the module, modify the counters, re-zip the
module then open it in Vassal to see how it all looks. After making
some changes to the actual module, later on if I need to do more
counter changes I need to repeat this process.

Another reason for opening and closing is I have VB scripts which do
such things as import counters by parsing the buildFile (this is a
Godsend!!), a script which takes counter names from a textfile and
automatically names all of the counters in the module and sorts them
alphabetically. These scripts mean I can churn out modules with
hundreds of scanned counters in a couple of days. But it does
involve lots of uncompressing and re-compressing of the module!

Hmmm, if only there was a way to open a module *folder* instead of a
zip file.

Ben

Ben







_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
tbyrne
 
Posts: 79
Joined: December 10th, 2007, 1:57 pm
Location: Chicago, IL

Postby uckelman » December 27th, 2007, 11:31 pm

Here's another build, with even more unclosed streams now closed explicitly:

http://www.nomic.net/~uckelman/tmp/vassal/VASSAL-3.1.0-svn2770.zip

Try this and let me know if you still experience this bug.
User avatar
uckelman
Site Admin
 
Posts: 8373
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

PreviousNext

Return to Technical Support & Bugs

Who is online

Users browsing this forum: No registered users and 4 guests