Create account / Log in

Log file prompting - Bug:1860941

Issues with the Vassal engine.

Moderators: Tim M, uckelman

Log file prompting - Bug:1860941

Postby bsmith » December 10th, 2007, 1:07 pm

You are playing back a PBEM log and simultanously recording a new log. When you reach the end of playback, the dialog box still appears asking if you would like to start a new log.

First, this dialog should not appear if you are already recording.
Second, and most important, if you accidentally choose to start a new log, it blows away the one you had already started!! So if you had spent 20 minutes doing your PBEM turn, you have just lost it all. I've had this happen and it isn't a pretty sight, is this being worked on?

cheers

Ben
User avatar
bsmith
Site Admin
 
Posts: 657
Joined: October 2nd, 2007, 4:47 pm

Postby Brent Easton » January 18th, 2008, 3:49 am

I have committed a fix for this bug to swampwallaby-merge@2854.

Joel, could you please merge this into your latest build?

Thanks,
Brent.
User avatar
Brent Easton
 
Posts: 2880
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Postby bsmith » January 18th, 2008, 4:21 am

Thanks Brent, nice.
Current PBEMs:- Tunisia, ASL, Vimeiro, Europe Engulfed, EuroFront II.
User avatar
bsmith
Site Admin
 
Posts: 657
Joined: October 2nd, 2007, 4:47 pm

Postby uckelman » January 18th, 2008, 8:49 pm

Ben, my builds from 2825 onward incorporate Brent's fix.

http://www.nomic.net/~uckelman/tmp/vass ... vn2858.zip

I've tried it myself and I think it works. My only concern is about the
wording of the Preferences associated with logging, in particular

"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something like

"Prompt to start new Log File after a Replay if not already logging?

so we should change that. Any suggestions for better wording?
User avatar
uckelman
Site Admin
 
Posts: 8380
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Log file prompting - Bug:1860941

Postby tar » January 18th, 2008, 9:41 pm

On Jan 18, 2008, at 12:49 PM, uckelman wrote:

Ben, my builds from 2825 onward incorporate Brent's fix.

http://www.nomic.net/~uckelman/tmp/vass ... vn2858.zip

I've tried it myself and I think it works. My only concern is about
the
wording of the Preferences associated with logging, in particular

"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something
like

"Prompt to start new Log File after a Replay if not already logging?

so we should change that. Any suggestions for better wording?

First of all change "Prompt" to "Ask". Less geeky, since this is for
ordinary users, not computer professionals.

"Ask to start new Log File after a Replay (unless already logging)"


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
tar
 
Posts: 776
Joined: January 2nd, 2008, 6:53 pm
Location: Los Angeles area

Log file prompting - Bug:1860941

Postby rk » January 18th, 2008, 9:44 pm

"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something like

"Prompt to start new Log File after a Replay if not already logging?

Do we really need "if not already logging" given that starting a new log file is impossible if you're already logging?

rk

Post generated using Mail2Forum (http://www.mail2forum.com)
rk
Site Admin
 
Posts: 536
Joined: October 21st, 2007, 3:31 am

Log file prompting - Bug:1860941

Postby Brent Easton » January 18th, 2008, 10:43 pm

I agree. I think people will get the idea without it being unneccesarily wordy.

*********** REPLY SEPARATOR ***********

On 18/01/2008 at 1:44 PM Rodney Kinney wrote:
"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something like

"Prompt to start new Log File after a Replay if not already logging?

Do we really need "if not already logging" given that starting a new log file is impossible if you're already logging?

rk


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> ____________________________________________________________
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au (b.easton@uws.edu.au)

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
Brent Easton
 
Posts: 2880
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Log file prompting - Bug:1860941

Postby tar » January 18th, 2008, 10:46 pm

On Jan 18, 2008, at 1:44 PM, Rodney Kinney wrote:

"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something
like

"Prompt to start new Log File after a Replay if not already logging?
Do we really need "if not already logging" given that starting a new
log file is impossible if you're already logging?

I would argue that it is needed.

Users and module designers who may be setting this preference might
not otherwise know that the new log file will only happen if logging
is not currently occurring. They might otherwise get the mistaken
impression that setting this preference will mean always asking to
start a new logfile, presumably closing any existing ones.



_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
tar
 
Posts: 776
Joined: January 2nd, 2008, 6:53 pm
Location: Los Angeles area

Log file prompting - Bug:1860941

Postby uckelman » January 18th, 2008, 11:11 pm

Thus spake Thomas Russ:
On Jan 18, 2008, at 1:44 PM, Rodney Kinney wrote:

"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something
like

"Prompt to start new Log File after a Replay if not already logging?
Do we really need "if not already logging" given that starting a new
log file is impossible if you're already logging?

I would argue that it is needed.

Users and module designers who may be setting this preference might
not otherwise know that the new log file will only happen if logging
is not currently occurring. They might otherwise get the mistaken
impression that setting this preference will mean always asking to
start a new logfile, presumably closing any existing ones.


The reason it bothers me is that it's now literally false, and there's
no indication that you should read it as being elliptical for anything
else.

What about "Prompt to ensure logging after replay?" This doesn't imply
(incorrectly) that a new log will begin if one is already going.

--
J.

_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
uckelman
Site Admin
 
Posts: 8380
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Log file prompting - Bug:1860941

Postby tar » January 18th, 2008, 11:21 pm

On Jan 18, 2008, at 3:11 PM, Joel Uckelman wrote:

Thus spake Thomas Russ:
On Jan 18, 2008, at 1:44 PM, Rodney Kinney wrote:

"Prompt to start new Log File after a Replay?"

because that isn't really what it means now. Instead it's something
like

"Prompt to start new Log File after a Replay if not already logging?
Do we really need "if not already logging" given that starting a new
log file is impossible if you're already logging?

I would argue that it is needed.

Users and module designers who may be setting this preference might
not otherwise know that the new log file will only happen if logging
is not currently occurring. They might otherwise get the mistaken
impression that setting this preference will mean always asking to
start a new logfile, presumably closing any existing ones.


The reason it bothers me is that it's now literally false, and there's
no indication that you should read it as being elliptical for anything
else.

What about "Prompt to ensure logging after replay?" This doesn't imply
(incorrectly) that a new log will begin if one is already going.

I think that is another option I had considered.

It's fine, with the slight substitution of "Ask" for "Prompt".


_______________________________________________
Messages mailing list
Messages@forums.vassalengine.org
http://forums.vassalengine.org/mailman/ ... engine.org

Post generated using Mail2Forum (http://www.mail2forum.com)
User avatar
tar
 
Posts: 776
Joined: January 2nd, 2008, 6:53 pm
Location: Los Angeles area

Log file prompting - Bug:1860941

Postby rk » January 19th, 2008, 1:24 am

What about "Prompt to ensure logging after replay?" This doesn't imply
(incorrectly) that a new log will begin if one is already going.

I definitely like that better.

rk

Post generated using Mail2Forum (http://www.mail2forum.com)
rk
Site Admin
 
Posts: 536
Joined: October 21st, 2007, 3:31 am


Return to Technical Support & Bugs

Who is online

Users browsing this forum: No registered users and 2 guests