Create account / Log in

Avoid empty reports from the turn counter

Suggestions for additional features for the module editor and Vassal engine.

Moderators: uckelman, Tim M

Avoid empty reports from the turn counter

Postby barbanera » March 5th, 2012, 4:46 pm

At present global hotkeys in the turn counter will report to the chat screen even if the report line is empty, which looks rather ugly and messy. Especially when there are several such carriage returns in a row.

It is probably a small tweak and would it then be possible to have in 3.2.0 such empty reporting removed?
barbanera
 
Posts: 395
Joined: January 12th, 2012, 2:27 pm

Re: Avoid empty reports from the turn counter

Postby uckelman » March 6th, 2012, 5:20 am

Thus spake barbanera:
>
> At present global hotkeys in the turn counter will report to the chat
> screen even if the report line is empty, which looks rather ugly and
> messy. Especially when there are several such carriage returns in a row.

Can you build me a test module exhibiting the problem?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8985
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Avoid empty reports from the turn counter

Postby barbanera » March 6th, 2012, 2:14 pm

Ok, when building a sample module I noticed that the forced report (even when empty) is from the turn counter itself, rather than from the hotkeys.

In other words: if the report format line is left empty in turn counter hotkeys then nothing will be reported. Apologies for my mistake.

However, if the report format in the turn counter itself is left empty there will still be an empty line in the chat screen (or, more precisely, a line with a single pink asterisk at the beginning).

Would it be possible to remove that empty line?

I have attached a sample module with a couple of hotkeys. Just move forward in the turn counter to see the empty lines on every turn.
Attachments
turns.vmod
(2.16 KiB) Downloaded 255 times
barbanera
 
Posts: 395
Joined: January 12th, 2012, 2:27 pm

Re: Avoid empty reports from the turn counter

Postby uckelman » June 2nd, 2013, 9:34 pm

Thus spake barbanera:
>
> However, if the report format in the turn counter itself is left empty
> there will still be an empty line in the chat screen (or, more
> precisely, a line with a single pink asterisk at the beginning).
>
> Would it be possible to remove that empty line?
>

I looked at this just now. I don't see any way to distinguish the case
in which the blank line is expected output from the case in which it
should be suppressed---so changing this would break any module which
was relying on the old behavior, and the old behavior is not obviously
wrong.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8985
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Avoid empty reports from the turn counter

Postby barbanera » July 23rd, 2013, 8:37 am

uckelman wrote:Thus spake barbanera:
>
> However, if the report format in the turn counter itself is left empty
> there will still be an empty line in the chat screen (or, more
> precisely, a line with a single pink asterisk at the beginning).
>
> Would it be possible to remove that empty line?
>

I looked at this just now. I don't see any way to distinguish the case
in which the blank line is expected output from the case in which it
should be suppressed---so changing this would break any module which
was relying on the old behavior, and the old behavior is not obviously
wrong.

--
J.


That's why I submitted this in the feature requests section, rather than
in the technical issues one.

I was hoping some sort of checkbox like "do not show empty report"
could be added in the turn counter.

Thanks.
barbanera
 
Posts: 395
Joined: January 12th, 2012, 2:27 pm


Return to Feature Requests

Who is online

Users browsing this forum: No registered users and 5 guests