Page 8 of 16

Re: Test builds for 3.3.0

PostPosted: March 30th, 2020, 9:49 pm
by uckelman
3.3.0-svn9329 fixes Inventory and ColorButton HiDPI rendering.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 7:37 am
by burzum51
Hi,

I updated my source code and the class "VASSAL.tools.swing.SwingUtils" is missing. Can you add it to svn/git ?

Thanks

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 10:01 am
by marktb1961
VASSAL version 3.3.0-svn9329

Platform. MacBook Pro (13-inch, Mid 2012), macOS Catalina 10.15.4

Test using Commands & Colors Medieval module v1.4 and replicated using Commands & Colors Napoleonic module v3.42

Movement trails are not showing.

Can be replicated and demonstrated in log files. Same log file will show movement trails in Vassal v3.2.17 and yet not in v3.3.0-svn9329.
I did not notice this problem when I was testing v3.3.0-svn9324 (can check later if need be).

See attachment for an example C&C Napoleonics vlog that should show the problem.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 10:08 am
by marktb1961
VASSAL version 3.3.0-svn9329 - update to "crash" bug reported for VASSAL version 3.3.0-svn9323

I still experience the crash that I previously reported for C&C Medieval module. I can ask the developer of this module if there is anything particular about what it does, if that might help. I will also watch out for the problem in C&C Ancients as that was the starting point for the medieval module.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 10:59 am
by marktb1961
VASSAL version 3.3.0-svn9329

Platform. MacBook Pro (13-inch, Mid 2012), macOS Catalina 10.15.4

Test using Commands & Colors Medieval module v1.4

Take picture function is broken.

Image taken with VASSAL version 3.2.17

Image taken with VASSAL version 3.3.0

Note "zoomed" partial view compared to same function performed using VASSAL version 3.2.17.

C&C Medieval vlog used to demonstrate behaviour:
GI03-Vulturnus2 021.vlog
C&C Medieval vlog used to demonstrate behaviour.
(156.29 KiB) Downloaded 45 times

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 3:14 pm
by uckelman
Thus spake burzum51:
> Hi,
>
> I updated my source code and the class "VASSAL.tools.swing.SwingUtils"
> is missing. Can you add it to svn/git ?

I forgot to commit it last night. It's there now. Thanks.

--
J.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 3:17 pm
by uckelman
Classes remaining to update for HiDPI support:

IconConfigurer
IconFamily
PropertySheet
Obscurable
NonRectangular
SetupStack
Visualizer
GridEditor
RegionGrid
HexGridNumbering
PolygonEditor
SquareGridNumbering
Zone
OpIcon
MenuScroller

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 3:35 pm
by burzum51
How you test if it's working ?

I launched a module where the card use NonRectangular but works fine for me.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 6:09 pm
by uckelman
Thus spake burzum51:
> How you test if it's working ?
>
> I launched a module where the card use NonRectangular but works fine
> for me.

The code which needs updating will in most cases be in a paint(Graphics)
method of a JComponent subclass. In NonRectangular, that's going to be
a method of the anonymous JPanel inside the Ed constructor, and the
place where that JComponent is displayed is in the dialog for the
NonRectangular piece trait in the Editor. The way to test that is to
check how that JPanel looks in 3.2.17, check how it looks in the most
recent test build under HiDPI scaling, and then check how it looks after
correcting it for HiDPI scaling.

Most of the remaining classes which need updating will have some
JComponent like that which is displayed in the Editor.

--
J.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 8:35 pm
by uckelman
Obscurable is done. (There was nothing to do for that one.)

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 10:07 pm
by uckelman
Zone is done. PolygonEditor didn't need modification.

Re: Test builds for 3.3.0

PostPosted: March 31st, 2020, 11:18 pm
by uckelman
HexGridNumbering and SquareGridNumbering are done.

Re: Test builds for 3.3.0

PostPosted: April 1st, 2020, 1:01 pm
by marktb1961
Apologies, I mis-reported my last two bug finds. I forgot to update my platform details as I had changed laptops for these two tests:
- movement trails don't appear in C&C Napoleonics Module (update - also don't appear in C&C Ancients)
- "take picture" function broke (tested in C&C Napoleonics and C&C Medieval)

The platform used was:
VASSAL version 3.3.0-svn9329 - since checked and still showing on version 3.3.0-svn9335
Platform: MacBook Pro (13-inch, 2016, Two Thunderbolt 3 ports), macOS Catalina 10.15.3

Repeating the tests on my other laptop MacBook Pro (13-inch, Mid 2012), macOS Catalina 10.15.4 does not reproduce either of these problems.

I guess this is Retina-related as the older MacBook Pro is non-retina if I recall correctly.

Mark

Re: Test builds for 3.3.0

PostPosted: April 1st, 2020, 9:50 pm
by uckelman
Thus spake marktb1961:
> Apologies, I mis-reported my last two bug finds. I forgot to update my
> platform details as I had changed laptops for these two tests:
> - movement trails don't appear in C&C Napoleonics Module (update - also
> don't appear in C&C Ancients)
> - "take picture" function broke (tested in C&C Napoleonics and C&C
> Medieval)
>
> The platform used was:
> VASSAL version 3.3.0-svn9329 - since checked and still showing on
> version 3.3.0-svn9335
> Platform: MacBook Pro (13-inch, 2016, Two Thunderbolt 3 ports), macOS
> Catalina 10.15.3
>
> Repeating the tests on my other laptop MacBook Pro (13-inch, Mid 2012),
> macOS Catalina 10.15.4 does not reproduce either of these problems.
>
> I guess this is Retina-related as the older MacBook Pro is non-retina if
> I recall correctly.

Thanks for clarifying. That's extremely helpful, since it narrows down
the causes to the HiDPI changes we've made.

--
J.

Re: Test builds for 3.3.0

PostPosted: April 2nd, 2020, 7:30 am
by ClaudioC
Hello Joel,
Is there a recommendation on what Java version to use? I am using Windows 1à, the 9335 build and Java 8 and would like to report some issues, but maybe I need 1st to upgrade Java?

In any case my issue is simple. Mapboard graphics look fine in the OCS Tunisia II module 1.06 (http://www.vassalengine.org/mediawiki/i ... _1_06.vmod)
but there are some Charts and tables windows that display some images containing mostly charts and texts
These images do not seem to be rendered optimally.
As an issue I reported some months ago, this suboptimal rendering appears when I use a 125% DPI scaling ratio on the windows display options. When I scale back to 100% the rendering is ok.
I can send you some images if needed.

Also I started VASL and loaded 1 board. There, when I select a unit in a hex, a red selection box appears somewhere else on the map. Are VASL issues to be reported too?

Thank you for your great work on the engine.