Create account / Log in

Test builds for 3.3.0

Discussion area for the development team.

Moderators: uckelman, Tim M

Re: Test builds for 3.3.0

Postby ClaudioC » April 19th, 2020, 12:49 pm

Brent
Ok, sign me up as your Test Pilot. I will also install the vassal project on Eclipse shortly.
you can contact me directly at claudio.ciardelli@gmail.com
Bye
User avatar
ClaudioC
 
Posts: 71
Joined: April 18th, 2018, 6:30 pm

Re: Test builds for 3.3.0

Postby uckelman » April 20th, 2020, 11:11 pm

I've uploaded 3.3.0-svn9359, which reverts svn9250, the commit we determined was causing the problem with the C&C Napoleonics Vimiero scenario.

Unfortunately, the undo issue I found with the Vimiero scenario also happens in 3.2.17, and isn't affected by svn9250 at all. I would still like to fix Bug 12538 for the 3.3.0 release, which svn9250 was intended to fix, but as I can't reproduce the problem it then causes I'm not well-positioned to do that.

Would someone who can reproduce the Vimiero problem be willing to create a minimal example module that demonstrates the problem?
User avatar
uckelman
Site Admin
 
Posts: 9135
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Test builds for 3.3.0

Postby Cattlesquat » April 21st, 2020, 3:06 am

I'm not sure what undo problem is in Vimiero, but in case you didn't see here is a minimal example module that will reproduce AN undo problem that is definitely in 3.2.17 and it will definitely reproduce it for you: http://www.vassalengine.org/wiki/File:UndoBug.vmod

Apologies if you already saw it.
User avatar
Cattlesquat
 
Posts: 966
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Test builds for 3.3.0

Postby marktb1961 » April 21st, 2020, 11:33 am

uckelman wrote:I would still like to fix Bug 12538 for the 3.3.0 release, which svn9250 was intended to fix, but as I can't reproduce the problem it then causes I'm not well-positioned to do that.

Would someone who can reproduce the Vimiero problem be willing to create a minimal example module that demonstrates the problem?


I don't seem to be able to view bugs via the "Tracker" (Bugzilla) function. Is it possible to gain read-access or am I not looking in the right place?
Platform: Vassal 3.4.12, MacOS Big Sur on iMac (27", mid-2020)
User avatar
marktb1961
 
Posts: 374
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England

Re: Test builds for 3.3.0

Postby uckelman » April 21st, 2020, 12:27 pm

Thus spake marktb1961:
>
> "uckelman" wrote:
> > I would still like to fix Bug 12538 for the 3.3.0 release, which
> > svn9250 was intended to fix, but as I can't reproduce the problem it
> > then causes I'm not well-positioned to do that.
> >
> > Would someone who can reproduce the Vimiero problem be willing to
> > create a minimal example module that demonstrates the problem?
>
>
> I don't seem to be able to view bugs via the "Tracker" (Bugzilla)
> function. Is it possible to gain read-access or am I not looking in the
> right place?

That particular bug was marked as "to be moderated" for no reason I can
see, so wasn't public. I've unset that. Try now.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 9135
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Test builds for 3.3.0

Postby uckelman » April 22nd, 2020, 10:25 pm

Cattlesquat wrote:I'm not sure what undo problem is in Vimiero, but in case you didn't see here is a minimal example module that will reproduce AN undo problem that is definitely in 3.2.17 and it will definitely reproduce it for you: http://www.vassalengine.org/wiki/File:UndoBug.vmod

Apologies if you already saw it.

I had a look. That's definitely not right---but as it already happened in 3.2.17 I'm not going to sink time into fixing it. If someone else wants to, I'm happy to review patches.
User avatar
uckelman
Site Admin
 
Posts: 9135
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Test builds for 3.3.0

Postby Cattlesquat » April 22nd, 2020, 11:50 pm

Okay thanks for looking. I dug around for probably 3 hours trying to find it, but at least so far am not able to track where it is misbehaving. The CLUES I can offer anyone who is willing to have a look is:
(1) If you add "does not stack"/Immobilized to the piece, the problem goes away. So something to do with stacks and reversing their moves.
(2) The problem occurs specifically when a piece (or stack) is moved, and somewhere during the processing of the trigger caused by the move the piece (or stack) gets moved a second time.
(3) It is ONLY when a piece/stack is dragged somewhere as the initial part of the movement. A sequence initiated by send-to-location does not manifest the problem.

I think it is quite likely that the movement is being correctly wrapped up in the Command (else the initial move wouldn't be working right in logfile/multiplayer play, but it IS working right), and that therefore the error is somehow in the execution of the UNDO -- possibly some part of it is being refused/ignored as a duplicate-to-the-same-location or something like that. But alas I have not found it so far.

I do agree with what Mark says, above, that this is probably at the root of what generates the occasional bug reports of "my undo didn't work".

I will keep looking but while I've looked at buckets of multiplayer synch code in my time, I'm still pretty new to the idiosyncrasies of Vassal's "stack" functionality.

Thanks again for having a peek.

Brian
User avatar
Cattlesquat
 
Posts: 966
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Test builds for 3.3.0

Postby uckelman » April 23rd, 2020, 12:23 am

I've uploaded 3.3.0-svn9360. This makes a few small adjustments to how we're building the packages. There should be no changes to the Windows and Mac packages between this and svn9359. The Linux package now has Java bundled with it.

Please give these a try. What I'm hoping to verify with this build is that I've not broken installation etc. for the packages, i.e., that they still run as before. There are no _code_ changes in svn9360.
User avatar
uckelman
Site Admin
 
Posts: 9135
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Test builds for 3.3.0

Postby marktb1961 » April 23rd, 2020, 10:27 am

uckelman wrote:I've uploaded 3.3.0-svn9360. This makes a few small adjustments to how we're building the packages. There should be no changes to the Windows and Mac packages between this and svn9359. The Linux package now has Java bundled with it.

Please give these a try. What I'm hoping to verify with this build is that I've not broken installation etc. for the packages, i.e., that they still run as before. There are no _code_ changes in svn9360.


Installed last night. Using it ok on my Mac.
Platform: Vassal 3.4.12, MacOS Big Sur on iMac (27", mid-2020)
User avatar
marktb1961
 
Posts: 374
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England

Re: Test builds for 3.3.0

Postby marktb1961 » April 24th, 2020, 10:40 am

uckelman wrote:Thus spake marktb1961:
> Re that MP3; there is something about the Medieval (and Ancients) module
> regarding sound. For some reason, the modules allow "unit marching"
> sounds to be turned off with an on screen button but the other type of
> sound(s) - dice rolling & card drawing - can only be turned off by
> substituting a silent sound. So I think there is more than one MP3
> embedded in the module. The developer suggested substituting silent
> MP3s as the way to disable all sounds but I never got round to doing
> that on my Mac. If there is a silent sound, I am not sure where it is
> used, perhaps it is just there as a convenience that can be swapped in
> for other sound files to disable them but not used in the standard
> configuration, or perhaps it gets triggered when the "unit sound off"
> button is pressed.

The ability to play sounds should not have been added (way back in 2.8)
without a switch for turning sounds off in the Preferences. I'm not
inclined to accept patches for new features, but if someone were to submit
a patch for that, I'd consider it.

I checked the contents of the CCMedievalV1_4.vmod and found only one MP3
there, silence.mp3.

Try 3.3.0-svn9355. I fixed a threading problem with the stream from which
MP3s are read. I suspect this will solve the problem.

--
J.


By the way, I was looking at C&C Ancients module content recently. The other sounds are provided via .wav files. I expect it is the same for Medieval.
Platform: Vassal 3.4.12, MacOS Big Sur on iMac (27", mid-2020)
User avatar
marktb1961
 
Posts: 374
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England

Re: Test builds for 3.3.0

Postby marktb1961 » April 24th, 2020, 10:49 am

marktb1961 wrote:3.3.0-svn9354 on MacBook Pro (with Retina) MacOS Catalina 10.15.4

Updated:-
...
- zoom bug when using the "saved map as PNG file" - confirming, fixed.



Re-visiting this with 3.3.0-svn9360, I find a difference with the image produced, compared to v3.2.17 which I missed when I tested previously. Though the image is captured in full, it is somehow scaled wrong in the output compared with v3.2.17.

v3.2.17 - https://www.dropbox.com/s/tziu1vo69u927 ... 7.png?dl=0

v3.3.0-svn9360 - https://www.dropbox.com/s/r00aprdk36gnj ... 0.png?dl=0
Platform: Vassal 3.4.12, MacOS Big Sur on iMac (27", mid-2020)
User avatar
marktb1961
 
Posts: 374
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England

Re: Test builds for 3.3.0

Postby uckelman » April 24th, 2020, 10:17 pm

Thus spake marktb1961:
>
> "marktb1961" wrote:
> > 3.3.0-svn9354 on MacBook Pro (with Retina) MacOS Catalina 10.15.4
> >
> > Updated:-
> > ...
> > - zoom bug when using the "saved map as PNG file" - confirming, fixed.
> >
> >
>
>
>
> Re-visiting this with 3.3.0-svn9360, I find a difference with the image
> produced, compared to v3.2.17 which I missed when I tested previously.
> Though the image is captured in full, it is somehow scaled wrong in the
> output compared with v3.2.17.
>
> v3.2.17 - https://www.dropbox.com/s/tziu1vo69u927 ... 7.png?dl=0[1]
>
> v3.3.0-svn9360 - https://www.dropbox.com/s/r00aprdk36gnj ...
> 0.png?dl=0[2]

Thanks for spotting this. Try 3.3.0-svn9361.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 9135
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Test builds for 3.3.0

Postby Cattlesquat » April 25th, 2020, 8:49 pm

I ask this fully aware the answer may be "no" --

Is there any chance that for 3.3 you'd be willing to add the following line to each of the three MouseWheelEvent listeners (last three methods) in ScrollPane.java:

Code: Select all
if (e.isControlDown() || e.isAltDown()) return;


Reason -- I'm dying to add some MouseWheel functionality in custom java classes, but alas the MouseWheel stuff is attached deep in the bowels of Map.java (no easy way to "override"), and it presently sucks up all the MouseWheel oxygen.

With that line, Ctrl+MouseWheel and Alt+MouseWheel would become available for custom-classing, without altering behavior for present modules.

Full code w/ proposed patch below.

Fingers crossed,

Brian

Code: Select all
    viewport.addMouseWheelListener(new MouseWheelListener() {
      public void mouseWheelMoved(MouseWheelEvent e) {
        if (e.getScrollAmount() == 0) return;
        if (e.isControlDown() || e.isAltDown()) return; //BR//

        if (e.getScrollType() == MouseWheelEvent.WHEEL_UNIT_SCROLL) {
          final JScrollBar bar = e.isShiftDown() ?
            horizontalScrollBar : verticalScrollBar;
          if (bar == null || !bar.isVisible()) return;

          bar.setValue(
            bar.getValue() +
            e.getUnitsToScroll() *
            bar.getUnitIncrement()
          );
        }
      }
    });

    verticalScrollBar.addMouseWheelListener(new MouseWheelListener() {
      public void mouseWheelMoved(MouseWheelEvent e) {
        if (e.getScrollAmount() == 0) return;
        if (e.isControlDown() || e.isAltDown()) return; //BR//

        if (e.getScrollType() == MouseWheelEvent.WHEEL_UNIT_SCROLL) {
          verticalScrollBar.setValue(
            verticalScrollBar.getValue() +
            e.getUnitsToScroll() *
            verticalScrollBar.getUnitIncrement()
          );
        }
      }
    });

    horizontalScrollBar.addMouseWheelListener(new MouseWheelListener() {
      public void mouseWheelMoved(MouseWheelEvent e) {
        if (e.getScrollAmount() == 0) return;
        if (e.isControlDown() || e.isAltDown()) return; //BR//

        if (e.getScrollType() == MouseWheelEvent.WHEEL_UNIT_SCROLL) {
          horizontalScrollBar.setValue(
            horizontalScrollBar.getValue() +
            e.getUnitsToScroll() *
            horizontalScrollBar.getUnitIncrement()
          );
        }
      }
    });
User avatar
Cattlesquat
 
Posts: 966
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Test builds for 3.3.0

Postby marktb1961 » April 26th, 2020, 5:24 pm

uckelman wrote:Thus spake marktb1961:
>
> "marktb1961" wrote:
> > 3.3.0-svn9354 on MacBook Pro (with Retina) MacOS Catalina 10.15.4
> >
> > Updated:-
> > ...
> > - zoom bug when using the "saved map as PNG file" - confirming, fixed.
> >
> >
> Re-visiting this with 3.3.0-svn9360, I find a difference with the image
> produced, compared to v3.2.17 which I missed when I tested previously.
> Though the image is captured in full, it is somehow scaled wrong in the
> output compared with v3.2.17.
>
> v3.2.17 - https://www.dropbox.com/s/tziu1vo69u927 ... 7.png?dl=0[1]
>
> v3.3.0-svn9360 - https://www.dropbox.com/s/r00aprdk36gnj ...
> 0.png?dl=0[2]

Thanks for spotting this. Try 3.3.0-svn9361.

--
J.


Yes, that worked in my test.
Platform: Vassal 3.4.12, MacOS Big Sur on iMac (27", mid-2020)
User avatar
marktb1961
 
Posts: 374
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England

Re: Test builds for 3.3.0

Postby uckelman » April 27th, 2020, 9:31 pm

3.3.0-beta1 is released: viewtopic.php?f=2&t=11699

Thanks everyone for all of your hard work getting us to this point.
User avatar
uckelman
Site Admin
 
Posts: 9135
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

PreviousNext

Return to Developers

Who is online

Users browsing this forum: No registered users and 3 guests