Create account / Log in

Test builds for 3.3.0

Discussion area for the development team.

Moderators: Tim M, uckelman

Re: Test builds for 3.3.0

Postby bolabola » November 16th, 2019, 12:35 pm

uckelman wrote:Thus spake bolabola:
>
> I have tested the latest version you provided with the ui scale system
> property set, and compared it to version 3.1.17. It works in exactly the
> same way as 3.1.17 and none of the rendering artifacts are present in
> this version.

What do you make of the rendering issue zgrose posted about earlier today?

--
J.


I have retested both versions just make I didn't miss anything. Both versions render the same on my 4K screen, and I am also running Windows 10. Both versions render relative small, because neither scale to desktop settings.

I thought that it might be something with the window title rendering, due to AWT using native windows, but that doesn't seems to be the case. I can't discern any difference between the to versions.

Seems that zgrose gets HDPI scaling on his 3.2.17 version, which I simply don't understand.
bolabola
 
Posts: 22
Joined: January 22nd, 2010, 8:14 pm
Location: Denmark, Copenhagen

Re: Test builds for 3.3.0

Postby zgrose » November 16th, 2019, 3:40 pm

I bit surprised myself because I remember VASSAL being small on my son's computer before. But things do constantly change.

Annotation 2019-11-16 093905.png
Annotation 2019-11-16 093905.png (165.55 KiB) Viewed 771 times
zgrose
 
Posts: 46
Joined: September 8th, 2010, 4:31 am

Re: Test builds for 3.3.0

Postby bolabola » November 16th, 2019, 5:30 pm

[quote="zgrose"]I bit surprised myself because I remember VASSAL being small on my son's computer before. But things do constantly change.

Ok, I think I might have an explanation for what is going on.

When I run 3.2.17, and look at the error log, I get:

2019-11-16 18:20:17,983 [0-main] INFO VASSAL.launch.StartUp - Starting
2019-11-16 18:20:17,984 [0-main] INFO VASSAL.launch.StartUp - OS Windows 8 6.2
2019-11-16 18:20:17,984 [0-main] INFO VASSAL.launch.StartUp - Java version 1.6.0_45
2019-11-16 18:20:17,985 [0-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.17
2019-11-16 18:20:18,010 [0-AWT-EventQueue-0] INFO VASSAL.launch.ModuleManager - Manager

Seems that I am running Vassal with Java 1.6, which I didn't even know I had installed.

When running Vassal 3.3.0 I get,

2019-11-16 18:21:38,360 [0-main] INFO VASSAL.launch.StartUp - Starting
2019-11-16 18:21:38,363 [0-main] INFO VASSAL.launch.StartUp - OS Windows 10 10.0
2019-11-16 18:21:38,363 [0-main] INFO VASSAL.launch.StartUp - Java version 13
2019-11-16 18:21:38,363 [0-main] INFO VASSAL.launch.StartUp - VASSAL version 3.3.0-svn9292
2019-11-16 18:21:38,433 [0-AWT-EventQueue-0] INFO VASSAL.launch.ModuleManager - Manager

which makes sense.

Turns out that Java 1.8 actually had some, but flawed, HDPI support. See https://bugs.openjdk.java.net/browse/JDK-8180815. If you look at Pardeep Sharma last comment, it all makes sense.

I think the reason your sons version might have looked small is most likely that he has been running an older version of Java, properly Java 6 or 7.

So apparently Java 8 has some HDPI support, though not perfect (blurred fonts), that doesn't affect Vassals rendering of images.

I'll try and fix my local setup to force Vassal 3.2.17 to run against Java 8 and see if I get the same result as you.
bolabola
 
Posts: 22
Joined: January 22nd, 2010, 8:14 pm
Location: Denmark, Copenhagen

Re: Test builds for 3.3.0

Postby bolabola » November 16th, 2019, 5:42 pm

I have tried installing a Java 8:

2019-11-16 18:38:43,641 [0-main] INFO VASSAL.launch.StartUp - Starting
2019-11-16 18:38:43,641 [0-main] INFO VASSAL.launch.StartUp - OS Windows 10 10.0
2019-11-16 18:38:43,641 [0-main] INFO VASSAL.launch.StartUp - Java version 1.8.0_231
2019-11-16 18:38:43,641 [0-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.17

I know I get the same result as you, zgrose. 3.2.17 is now scaled, but with somewhat (not to bad) blurred texts.

So unfortunately it seems that with this in mind, using the -Dsun.java2d.uiScale=1.0 system property in Vassal 3.3.0 would be a regression for users who has been running Vassal on Java 8.
bolabola
 
Posts: 22
Joined: January 22nd, 2010, 8:14 pm
Location: Denmark, Copenhagen

Previous

Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests