Create account / Log in

Checkstyle Failing 15000+ times in "bsh" and "netbeans"

Discussion area for the development team.

Moderators: uckelman, Tim M

Checkstyle Failing 15000+ times in "bsh" and "netbeans"

Postby Cattlesquat » July 20th, 2020, 2:46 pm

Somehow even a bunch of rain-dances hasn't convinced all the bsh & netbeans to hard-fail on CheckStyle stuff

"}" at column 11 should be alone on a line", etc, etc.

I think my initial mistake was doing a "maven clean".

To be clear: building from the command line shows no problems. Building in Eclipse shows unending errors.
User avatar
Cattlesquat
 
Posts: 953
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Checkstyle Failing 15000+ times in "bsh" and "netbeans"

Postby Cattlesquat » July 20th, 2020, 2:56 pm

Okay, so I was able to go to "bsh", and each of the four "org.xxxxx" entries, right click on them, find the "Check Style" entry on the long context menu, and select "Clear Check Style violations".

This got rid of the errors, but they come back (necessitating repeating that process on five entries) any time I "clean" the project.

So it might be helpful if checkstyle is able to be told to ignore bsh & org.* in a more permanent way? If that's possible?
User avatar
Cattlesquat
 
Posts: 953
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Checkstyle Failing 15000+ times in "bsh" and "netbeans"

Postby Flint1b » July 20th, 2020, 4:03 pm

I did add bsh.* and org.* to the checkstyle suppression list but the eclipse checktyle plugin seems to not pick that up. I think there is one other way of declaring them off limits to checkstyle, I'll cook up a quick PR for this.
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: Checkstyle Failing 15000+ times in "bsh" and "netbeans"

Postby Flint1b » July 20th, 2020, 4:12 pm

This here should probably work for Eclipse: https://github.com/vassalengine/vassal/pull/108
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: Checkstyle Failing 15000+ times in "bsh" and "netbeans"

Postby Cattlesquat » July 20th, 2020, 4:14 pm

Excellent, thanks! Now have have a look at my latest question in the PR for 13197 :)
User avatar
Cattlesquat
 
Posts: 953
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA


Return to Developers

Who is online

Users browsing this forum: No registered users and 4 guests