Create account / Log in

FYI - problem saving modules in recent branches

Discussion area for the development team.

Moderators: uckelman, Tim M

FYI - problem saving modules in recent branches

Postby Cattlesquat » July 28th, 2020, 4:24 pm

I was just working on a branch that I branched off of the 13197 bugfix branch, and I noticed that every time I try to save a module, even a "new module", I get a "couldn't write the file" error and it just leaves the tmp1234123413.zip file.

And I thought "that's odd, doesn't *seem* related to anything I've just done".

So I pulled down "master" itself and tried creating a "new module" and Save-As-ing it -- FAIL.

Also the message it puts up is weird, it acts like it can't write the TMP file even though it looks like it's failing to rename it to vmod.

So anyway there you have it.

Brian
User avatar
Cattlesquat
 
Posts: 942
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: FYI - problem saving modules in recent branches

Postby Flint1b » July 28th, 2020, 5:06 pm

Let's revert this guy to my original proposal, PR #63 https://github.com/vassalengine/vassal/pull/63, 1st commit, just put a check around FileUtils.forceDelete(archiveFile).

Everything else worked fine, no need to change the whole thing, I/O code is too difficult to test for us, too many OSes, too many users using network drives, and we don't have a single unit test for this.
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: FYI - problem saving modules in recent branches

Postby uckelman » July 28th, 2020, 5:26 pm

Thus spake Flint1b:
> [This message has been edited.]
>
> Let's revert this guy to my original proposal, PR #63
> https://github.com/vassalengine/vassal/pull/63[1], 1st commit, just put
> a check around FileUtils.forceDelete(archiveFile).

That's what I have on the bug13014 branch.

I'm looking at switching all of this out for the ZIP FileSystemProvider,
as that would let us delete quite a lot of fidly code for contenting with
java.util.zip, and I suspect will also fix the bad mtime bug which trips
up tiling.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8985
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: FYI - problem saving modules in recent branches

Postby Flint1b » July 28th, 2020, 6:36 pm

Sounds good.
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: FYI - problem saving modules in recent branches

Postby m3tan » July 28th, 2020, 6:53 pm

Cattlesquat wrote:I was just working on a branch that I branched off of the 13197 bugfix branch, and I noticed that every time I try to save a module, even a "new module", I get a "couldn't write the file" error and it just leaves the tmp1234123413.zip file.

And I thought "that's odd, doesn't *seem* related to anything I've just done".

So I pulled down "master" itself and tried creating a "new module" and Save-As-ing it -- FAIL.

Also the message it puts up is weird, it acts like it can't write the TMP file even though it looks like it's failing to rename it to vmod.

So anyway there you have it.

Brian

I've also experienced the same issue with some of the test builds, but figured it wasn't worth mentioning since they are after all test builds...
User avatar
m3tan
 
Posts: 209
Joined: August 12th, 2018, 11:49 pm

Re: FYI - problem saving modules in recent branches

Postby uckelman » July 28th, 2020, 6:57 pm

Thus spake m3tan:
>
> I've also experienced the same issue with some of the test builds, but
> figured it wasn't worth mentioning since they are after all test
> builds...

I recommend mentioning problems you find in test builds immediately. We
can't fix problems until we're aware of them.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8985
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: FYI - problem saving modules in recent branches

Postby m3tan » July 28th, 2020, 7:00 pm

Got it. I'm just starting to toe tap on the developer side of things and had assumed test builds were just to fix/test a single subset of bugs/features. Especially with the appearance of the SNAPSHOT builds, but will be sure to report all bugs going forward.
User avatar
m3tan
 
Posts: 209
Joined: August 12th, 2018, 11:49 pm

Re: FYI - problem saving modules in recent branches

Postby Cattlesquat » July 28th, 2020, 7:00 pm

Any time you see something broken that wasn't broken before is definitely a good time to report it :-) Test builds often break things that we didn't notice we were breaking, that didn't seem related to the thing we thought we were testing. I mean you're exactly right about what test builds are built for, it's just that we don't always immediately notice the "side effects".
User avatar
Cattlesquat
 
Posts: 942
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: FYI - problem saving modules in recent branches

Postby uckelman » July 28th, 2020, 7:15 pm

You'll also see quite a few conversations in the forum which go like this:

"I noticed X is broken just now."

"X has been broken for 5 years."

"WHAT!? WHY DID NO ONE TELL US?!"

I hate those conversations and would like to have as few of them as
possible. Reporting bugs promptly helps with that.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8985
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: FYI - problem saving modules in recent branches

Postby Flint1b » July 28th, 2020, 10:05 pm

uckelman wrote:I'm looking at switching all of this out for the ZIP FileSystemProvider,
as that would let us delete quite a lot of fidly code for contenting with
java.util.zip, and I suspect will also fix the bad mtime bug which trips
up tiling.


Hold on.. haven't read this part before. This sounds a bit like... there's a german and russian idiom for this: "shooting sparrows with cannons". And the I/O code is quite sensitive and needs thorough testing on all 3 OSes and in various network storage scenarios.. I'd just quick fix this initial "cannot delete what is not there" bug and prioritize further improvements all the way to the bottom of the todo list.
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina


Return to Developers

Who is online

Users browsing this forum: No registered users and 3 guests