Create account / Log in

Am I doing this right?

Discussion area for the development team.

Moderators: uckelman, Tim M

Re: Am I doing this right?

Postby Cattlesquat » July 30th, 2020, 2:18 am

Wow. To be clear deleting a Neutral Country marker is probably sending some Global Key Commands -- because it wants to put the appropriate Event marker on the Turn Track, and in some cases (Bulgaria and Romania) deploy some troops from the Reinforcement Card to the map. But... 15,000 times?!
User avatar
Cattlesquat
 
Posts: 941
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Am I doing this right?

Postby Flint1b » July 30th, 2020, 2:21 am

Flint1b wrote:For the reference, when I run Paths of Glory 9.8 on Vassal 3.3.2:
- then the Player starts loading and loads for about 2:20min until it finishes loading and the CPU usage goes down


With the changes from the the PieceCloner.clone() PR, this loads in about 1:00 minute.

I don't trust the visualvm profiler, it gave me completely different results than JProfiler, and the change applied after the JProfiler result got me a huge performance increase. Profiling Java is a very complex matter and there is a reason why all the good profilers cost money.
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: Am I doing this right?

Postby Cattlesquat » July 30th, 2020, 2:29 am

Is there one that costs a couple hundred dollars that we should get?
User avatar
Cattlesquat
 
Posts: 941
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Am I doing this right?

Postby Flint1b » July 30th, 2020, 2:41 am

The most popular high-performance minecraft server uses the YourKit profiler, it costs money but they give free licenses to open source projects if the project adds a reference to their website. I hear Vassal used to have this license already and YourKit gladly supplied it, it just wasn't renewed at some point.
User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: Am I doing this right?

Postby Brent Easton » July 30th, 2020, 3:04 am

I have emailed Yourkit requesting a new License. We will need to add a link to them back in to our project page, I have asked for details of what they need.
User avatar
Brent Easton
 
Posts: 3225
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: Am I doing this right?

Postby uckelman » July 30th, 2020, 10:19 am

Thus spake Cattlesquat:
> Wow. To be clear deleting a Neutral Country marker is probably sending
> some Global Key Commands -- because it wants to put the appropriate
> Event marker on the Turn Track, and in some cases (Bulgaria and Romania)
> deploy some troops from the Reinforcement Card to the map. But... 15,000
> times?!

IIRC, I removed the markers for Romania and Italy, and I removed Bulgaria
but I don't remember if that was before I stopped profiling. Either way,
it seemed like too many.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8980
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Previous

Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests

cron