Create account / Log in

Master branch broken - No traits showing Piece Definer

Discussion area for the development team.

Moderators: uckelman, Tim M

Master branch broken - No traits showing Piece Definer

Postby Brent Easton » July 30th, 2020, 12:49 am

The last couple of 'cleanup' commits to PieceDefiner have broken it completely, it now loads up with an empty list of traits in the left hand trait list. Commit 7fcf64a seems to have done the damage.
User avatar
Brent Easton
 
Posts: 3229
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: Master branch broken - No traits showing Piece Definer

Postby Flint1b » July 30th, 2020, 2:35 am

User avatar
Flint1b
 
Posts: 461
Joined: May 19th, 2020, 12:27 am
Location: Colonia Agrippina

Re: Master branch broken - No traits showing Piece Definer

Postby Brent Easton » July 30th, 2020, 2:51 am

It's the Renderer -> GamePieceRenderer refactor that is the problem, everything else is fine.
User avatar
Brent Easton
 
Posts: 3229
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: Master branch broken - No traits showing Piece Definer

Postby uckelman » July 30th, 2020, 6:32 pm

Thus spake Brent Easton:
> It's the Renderer -> GamePieceRenderer refactor that is the problem,
> everything else is fine.

I've merged PR 143 which restores it to how it was. Try now.
--
J.
User avatar
uckelman
Site Admin
 
Posts: 9014
Joined: December 10th, 2007, 9:48 am
Location: Durham, England


Return to Developers

Who is online

Users browsing this forum: No registered users and 5 guests