Create account / Log in

VASSAL-src trunk missing package

Discussion area for the development team.

Moderator: bsmith

Re: [messages] [Developers] Re: VASSAL-src trunk missing pac

Postby uckelman » September 28th, 2011, 11:33 am

Thus spake lancel:
> Oh, I just noticed that there are quite a few lines of "FIXME" in that
> Board.java file, especially around the problem areas. I wonder if they
> are related.

Many of those indicate that the exceptions being caught are bugs if
they occur, but won't be bugs if/when some other code is written. I
doubt that those are relevant.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: [messages] [Developers] Re: VASSAL-src trunk missing pac

Postby uckelman » October 2nd, 2011, 3:24 pm

Thus spake lancel:
> I added the changes as suggested but instead of the crash, I got blank
> maps. So, it seems to be that something new in 3.2's Vassalengine code
> is not working well with VASL. (As an experiment, instead of the
> current release of VASL.mod, I replaced it with a copy of the VASL.mod
> that was built with 3.2's code and loaded it up with Vassal 3.1 GA
> build. Then I had no problem loading up the mapboard.)
>
> I have not checked in the change done in ASLboard.java. I will do it
> soon.

You might have been having problems with bugs in the trunk which have
been fixed since you posted this. Do you setill have problems with
trunk@HEAD?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: VASSAL-src trunk missing package

Postby lancel » October 21st, 2011, 3:41 am

Yes, unfortunately as late as the trunk dated on 10/11/11. I checked for the map object's null value. That fixed up the crash but the VASL board cannot be loaded at all. When I click the "Finish" button, the VASL controls panel will post lines of output like this:

- Bad Data in Module: Image not found 2980ec082ac2a9411d7e0f......

I thought someone working on VASL might have noticed this by now but still it seemed to be only me. So, any clue on what is going on here or where the above error could have come from?

Lance
lancel
 
Posts: 93
Joined: August 30th, 2010, 3:47 pm
Location: NY, NY

Re: [messages] [Developers] Re: VASSAL-src trunk missing pac

Postby uckelman » October 24th, 2011, 8:29 pm

Thus spake lancel:
> Yes, unfortunately as late as the trunk dated on 10/11/11. I checked
> for the map object's null value. That fixed up the crash but the VASL
> board cannot be loaded at all. When I click the "Finish" button, the
> VASL controls panel will post lines of output like this:
>
> - Bad Data in Module: Image not found 2980ec082ac2a9411d7e0f......
>
> I thought someone working on VASL might have noticed this by now but
> still it seemed to be only me. So, any clue on what is going on here or
> where the above error could have come from?
>

The filename in the error message is for a map tile. (Map tiles are
identified by the SHA1 of some of their identifying data. See
TileUtils.tileName() if you want to see exactly how this is computed.)

What's the full error message? This appears to be truncated.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: VASSAL-src trunk missing package

Postby uckelman » October 26th, 2011, 9:24 pm

Lance, would you like me to take a look at this, since I know the tile loading code well? What revision in the VASL repo are you running?
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: VASSAL-src trunk missing package

Postby lancel » October 29th, 2011, 4:38 am

Joel,

Please feel free to take a look. I can't use the VASL.mod out there because those released VASL mod builds are still using the MappedBufferedImage.class that you took out in Vassal 3.2. Now I think I realize why I am the only one who have seen it. :-)

The VASLmod file that I use for testing is built with a modified ASLBoard.java in the ASL-src tree that removes its dependency on the missing MappedBufferedImage.class. For some reason, I thought that you checked that change into ASLBoard.java but then as I just checked, it is still not there.

I am also attaching all the Bad Data error outputs.

Lance
Attachments
BadData.jpg
Bad Data errors.
BadData.jpg (117.33 KiB) Viewed 675 times
lancel
 
Posts: 93
Joined: August 30th, 2010, 3:47 pm
Location: NY, NY

Re: VASSAL-src trunk missing package

Postby lancel » November 5th, 2011, 2:04 am

I just checked in the change in ASLBoard.java to my branch that removes its dependency on the MappedBufferedImage.class.

Lance
lancel
 
Posts: 93
Joined: August 30th, 2010, 3:47 pm
Location: NY, NY

Re: [messages] [Developers] Re: VASSAL-src trunk missing pac

Postby uckelman » November 8th, 2011, 10:41 pm

Thus spake lancel:
> I just checked in the change in ASLBoard.java to my branch that removes
> its dependency on the MappedBufferedImage.class.

You also checked 7993 into the trunk. I try to review the code going
into the trunk, so I'd prefer if you'd let me merge to the trunk
instead. (The change looks ok, though.)

Is the VASL problem fixed now?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: VASSAL-src trunk missing package

Postby lancel » November 13th, 2011, 2:39 am

Sorry about that. I thought I checked it only into my branch. I have not looked into that problem since my last post as I was waiting for your reply.

I wonder if the packaging of the VASL.mod needs to be done in a different way as I don't see how your code change affects only VASL but not others.

Lance
lancel
 
Posts: 93
Joined: August 30th, 2010, 3:47 pm
Location: NY, NY

Re: [messages] [Developers] Re: VASSAL-src trunk missing pac

Postby uckelman » November 13th, 2011, 5:32 pm

Thus spake lancel:
> Sorry about that. I thought I checked it only into my branch. I have
> not looked into that problem since my last post as I was waiting for
> your reply.

It's not a problem, just wanted to let you know for the future.

> I wonder if the packaging of the VASL.mod needs to be done in a
> different way as I don't see how your code change affects only VASL but
> not others.

VASL has numerous custom classes which extend ones in VASSAL. My guess
is that one of them is extending a class in a way which was ok in 3.1
but is not ok in 3.2.

I might see if there's anyting I can do this evening.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: VASSAL-src trunk missing package

Postby lancel » November 16th, 2011, 3:36 am

I just updated the latest VASSALengine 3.2 code and noticed that the latest changes broke the ASL src code in at least six files. For example, in ASLHexGrid.java, it has:

public class ASLHexGrid extends HexGrid {
......
public ASLHexGrid(double height, boolean alt) {
super(height, alt); ---------> error now in Eclipse IDE after updating the VASSALengine code.
}

Going back to HexGrid.java, I noticed that the latest version of this file had a huge change and that constructor needed by ASLHexGrid above is no longer there. HexGridX.java also does not have it.

I guess I need to dig a bit more to see what is going on with the new VASSALengine code.

Lance
lancel
 
Posts: 93
Joined: August 30th, 2010, 3:47 pm
Location: NY, NY

Re: [messages] [Developers] Re: VASSAL-src trunk missing pac

Postby uckelman » November 16th, 2011, 5:07 pm

Thus spake lancel:
> I just updated the latest VASSALengine 3.2 code and noticed that the
> latest changes broke the ASL src code in at least six files. For
> example, in ASLHexGrid.java, it has:
>
> public class ASLHexGrid extends HexGrid {
> ......
> public ASLHexGrid(double height, boolean alt) {
> super(height, alt); ---------> error now in Eclipse IDE after
> updating the VASSALengine code.
> }
>
> Going back to HexGrid.java, I noticed that the latest version of this
> file had a huge change and that constructor needed by ASLHexGrid above
> is no longer there. HexGridX.java also does not have it.
>
> I guess I need to dig a bit more to see what is going on with the new
> VASSALengine code.

Ah, right. I suspected this might be a problem. These changes come from
Pieter's refactoring of the grid code.

Pieter, can you advise Lance on what needs changing for VASL?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 6898
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: VASSAL-src trunk missing package

Postby lancel » November 19th, 2011, 5:01 am

Let me upload the screenshot of the errors that are left so far. I have sort of fixed up something on the ASL side. Let me know if I should post the screenshot in another thread. Thanks.
Attachments
HexGrid.jpg
HexGrid.jpg (238.73 KiB) Viewed 588 times
lancel
 
Posts: 93
Joined: August 30th, 2010, 3:47 pm
Location: NY, NY

Previous

Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests