Create account / Log in

3.2 roundup

Discussion area for the development team.

Moderator: bsmith

3.2 roundup

Postby uckelman » October 27th, 2011, 10:22 pm

I'm trying to get a handle on what's left to do before we can release a 3.2 beta.

* I know that Pieter is waiting (patiently) for me to merge his hex grid changes. I started looking these over this evening.

* We need to come to some sort of resolution on the Windows LaF problem.

Is anyone else waiting on me for things?

What is everyone else working on presently?
User avatar
uckelman
Site Admin
 
Posts: 7122
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: 3.2 roundup

Postby DrNostromo » October 28th, 2011, 2:44 am

I posted a couple things in the Technical Support & Bugs forum in this thread here:

viewtopic.php?f=3&t=4574

I'm not sure if they're bugs or not.
Dr_Nostromo
Creator - To Be King, Trivial Wars, WWIV
Dr Nostromo's Place
Dr Nostromo's Forum
User avatar
DrNostromo
 
Posts: 836
Joined: December 21st, 2007, 3:54 am
Location: Wine Country, Cal. USA

viewofheaven's list of current pending work

Postby viewofheaven » October 28th, 2011, 3:36 pm

  • RecursionLimiter currently erroneously limits call stack/depth, not recursion alone. Still waiting on Brent to gimme the green light to correct this.
  • After RecursionLimiter is corrected, I wanna make TriggerAction handle animations (via separate threads)
  • Trying to correct oddball Traits engine so newbies and veterans can use Traits in top-down, logical style/flow

About oddball Traits engine, I just discovered this:
  • Variables (DynamicProperty or Marker) are, so to speak, "declared and put into scope top-down" (top one first, then 2nd and so on)
  • Commands are executed bottom-up
Are my assumptions correct? I haven't checked the 2nd point about command-execution order.

Is it worth it for me to add a "Function" trait that lets module designers lay out variables and commands in logical (ala modern day programming) style? In the Funtion trait, I would attempt to use most/all existing library of Traits so that veterans find the Function trait familiar.

Or should I just start rewriting all existing Traits into Beanshell methods instead?

About Python for scripting, I feel that we can test out our translation of existing Traits into script methods/functions first, with Beanshell. It shouldn't be too much effort to port to Python from Beanshell.

The Traits engine is unraveling my ability as a programmer! That is, after designing a module with the Traits engine for some time, I find myself unable to program anymore in Java! My logic and flow is all warped. My brain hurts like it's been twisted inside out.
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: 3.2 roundup

Postby mroyer » October 28th, 2011, 8:31 pm

Brent Easton acknowledged reproducing the behavior described in the quote and logged it as Bug 4050. I don't know if he intends to fix it for 3.2. I'd rate the issue as low-priority, though it can be annoying at times. (I originally reported this here: viewtopic.php?f=5&t=4499&start=30#p26040 )

mroyer wrote:
mroyer wrote:On a possibly related note, as the game wore on it became clear that there maybe a couple of other ephemeral issue going on. They are is difficult to report and describe as we couldn't cause them to repeat regularly...


Okay, I think we've nailed down a repeatable sequence of events to reliably recreate the issue:

Select a piece with left-click
Right click piece to bring up drop-down menu
Don't select anything on menu - instead, left-click elsewhere on the game board
The piece jumps to the position pointed to with the left-click

We are using the VASSAL-3.2.0-svn7890-windows.exe build and are playing online. I haven't tried it off line yet, but I expect it will happen there as well and is not related to being online.

-Mark R.
mroyer
 
Posts: 166
Joined: March 4th, 2011, 5:06 pm
Location: Massachusetts

Re: 3.2 roundup

Postby viewofheaven » October 29th, 2011, 5:42 am

mroyer wrote:Brent Easton acknowledged reproducing the behavior described in the quote and logged it as Bug 4050.

I see this bug too! Yes, it is terribly annoying, and I would list it as broken. I'll fix it within these couple of days. (I'll commit my fixes the moment my end-of-line character issue is resolved or allayed at here).
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: 3.2 roundup

Postby Brent Easton » October 30th, 2011, 12:05 pm

Brent Easton acknowledged reproducing the behavior described in the quote and logged it as Bug 4050. I don't know if he intends to fix it for 3.2.


The bug only occurs when the Windows native L&F is turned on, and I believe it is most likely a Java bug. The code involved is extemely complex with multiple layers of Listeners interacting accross multiple classes. I am glad you will have a fix for it in the next day or two Jon.

B.
User avatar
Brent Easton
 
Posts: 2620
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: 3.2 roundup

Postby Brent Easton » October 30th, 2011, 12:12 pm

I'm trying to get a handle on what's left to do before we can release a 3.2 beta.


I am working on cleaning up and standardising the 'board-bases' editors (Deck/Stack Positioner, Irregular Grid region Editor, Zone Shape Editor), extracting duplicated code and fixing bugs. That's pretty much it for me apart from looking at bugs and general issues raised.

Brent.
User avatar
Brent Easton
 
Posts: 2620
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: 3.2 roundup

Postby viewofheaven » November 1st, 2011, 12:24 pm

Brent Easton wrote:
Brent Easton acknowledged reproducing the behavior described in the quote and logged it as Bug 4050. I don't know if he intends to fix it for 3.2.


The bug only occurs when the Windows native L&F is turned on, and I believe it is most likely a Java bug. The code involved is extemely complex with multiple layers of Listeners interacting accross multiple classes. I am glad you will have a fix for it in the next day or two Jon.

B.

Oh. Guess I'm in over my head. Anyway, I'm just trying to help out. Thanks for the heads up!

I'll put in a couple of days to see if I can get that bug.

By the way, should I just attach the patches to the tracker, and let you commit the patches? The bugs are assigned to you. I figured you must be busy.

Also, why is your account on the tracker listed as "unknown"? Should we ask Joel to look into rectifying your account?
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: [messages] [Developers] Re: 3.2 roundup

Postby uckelman » November 1st, 2011, 12:46 pm

Thus spake viewofheaven:
>
> By the way, should I just attach the patches to the tracker, and let you
> commit the patches? The bugs are assigned to you. I figured you must be
> busy.

Commit changes to a branch, then note the changesets in the tracker.

> Also, why is your account on the tracker listed as "unknown"? Should we
> ask Joel to look into rectifying your account?

This is Bug 4091:

http://www.vassalengine.org/tracker/sho ... gi?id=4091

It's odd, because it appears to happen only with Brent's account, and it
recurs almost immediately after I change the name associated with
Brent's account it in the database. Fixing this will require looking at
the code in Bugzilla to see under what conditions the name can be reset.
If you'd like to do that, I'd appreciate it.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 7122
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: [messages] [Developers] Re: 3.2 roundup

Postby viewofheaven » November 1st, 2011, 10:29 pm

uckelman wrote:
viewofheaven wrote:By the way, should I just attach the patches to the tracker, and let you commit the patches? The bugs are assigned to you. I figured you must be busy.

Commit changes to a branch, then note the changesets in the tracker.

Aye aye, will do. Just thought I'd let Brent commit my patches to bugs assigned to him, simply because I hope for peer review of my code.

uckelman wrote:
viewofheaven wrote:Also, why is your account on the tracker listed as "unknown"? Should we ask Joel to look into rectifying your account?

This is Bug 4091:

http://www.vassalengine.org/tracker/sho ... gi?id=4091

It's odd, because it appears to happen only with Brent's account, and it
recurs almost immediately after I change the name associated with
Brent's account it in the database. Fixing this will require looking at
the code in Bugzilla to see under what conditions the name can be reset.
If you'd like to do that, I'd appreciate it.

Ok, I'll get on this. Really irritating bug. I'd be really distracted if my contributions on Vassal keep getting listed as "from unknown".
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: 3.2 roundup

Postby viewofheaven » November 1st, 2011, 10:45 pm

Brent Easton wrote:
Brent Easton acknowledged reproducing the behavior described in the quote and logged it as Bug 4050. I don't know if he intends to fix it for 3.2.


The bug only occurs when the Windows native L&F is turned on, and I believe it is most likely a Java bug. The code involved is extemely complex with multiple layers of Listeners interacting accross multiple classes. I am glad you will have a fix for it in the next day or two Jon.

I submitted a patch for this just now. The bug is in a major logic flaw (from 1 tiny line) in PieceMover.

By the way, I'm lazy as heck when it comes to designing games (read my initial hunt for a game designer to how I eventually latched on to an avid game designer).

I'm good with reverse-engineering, which is why I kill bugs pretty quickly. But that's all I do.

If you ask me to "just shut up and finish up your suggested Pandemic game polish", which I believe (perhaps mistakenly) I can technically do, I'll be procrastinating. I promised to redo Pandemic in 2 days, and never got around to it! For the record, I think I'll take much longer than most of you guys to redo Pandemic.

So, feel free to throw bugs at me and tell me to "just shut up and eat bugs"! Heh. :) Yeah, I'm willing to take it upon myself to be responsible for bugs in Vassal, cos I can do that pretty easily. Rest of you guys should help me create games I can enjoy!

Commander, dilithium chambers are at full. Warp cores stable and ready. Engineering is good to go! Sir!
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: [messages] [Developers] Re: 3.2 roundup

Postby uckelman » November 1st, 2011, 11:16 pm

Thus spake viewofheaven:
>
> So, feel free to throw bugs at me and tell me to "just shut up and eat
> bugs"! Heh. :) Yeah, I'm willing to take it upon myself to be
> responsible for bugs in Vassal, cos I can do that pretty easily. Rest of
> you guys should help me create games I can enjoy!

Here's the query for open bugs:

http://www.vassalengine.org/tracker/bug ... plications

There are lots which haven't been looked at yet (many of which are
likely to be duplicates, and should be marked so).

Here you can see the most-reported open bugs:

http://www.vassalengine.org/tracker/dup ... openonly=1

Go forth and fix bugs. There's certainly no shortage of them.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 7122
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: 3.2 roundup

Postby Brent Easton » November 2nd, 2011, 10:37 am

I submitted a patch for this just now. The bug is in a major logic flaw (from 1 tiny line) in PieceMover.


Jon,

With your 'fix' in place, you can no longer drag counters from GamePiece palette and drop them on a map. They just dissappear.

This existing code works perfectly with Java L&F turned on, but is only broken with Windows L&F turned on. This is why I suspect a Java bug in the Windows L&F. There appears to be a difference between the Java and Windows LaF's in the sequence of Mouse events generated when you cancel a popup window by clicking away from it.

Regards.
Brent.
User avatar
Brent Easton
 
Posts: 2620
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: [messages] [Developers] Re: 3.2 roundup

Postby uckelman » November 2nd, 2011, 9:09 pm

Thus spake Brent Easton:
>
> This existing code works perfectly with Java L&F turned on, but is only
> broken with Windows L&F turned on. This is why I suspect a Java bug in
> the Windows L&F. There appears to be a difference between the Java and
> Windows LaF's in the sequence of Mouse events generated when you cancel
> a popup window by clicking away from it.

This might be a reason to give up on the Windows L&F. That would also
solve our font size problem.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 7122
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: [messages] [Developers] Re: 3.2 roundup

Postby Brent Easton » November 2nd, 2011, 9:31 pm

>This might be a reason to give up on the Windows L&F. That would also
>solve our font size problem.

Will anyone be sorry to see it go?
User avatar
Brent Easton
 
Posts: 2620
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Next

Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests