Create account / Log in

3.2 roundup

Discussion area for the development team.

Moderator: bsmith

Bug 4050 most likely not a Java (Win L&F) bug

Postby viewofheaven » November 3rd, 2011, 3:29 am

Brent Easton wrote:With your 'fix' in place, you can no longer drag counters from GamePiece palette and drop them on a map. They just dissappear.

Sorry! Submitted a new patch. Didn't cater for the case where pieces are dragged between different maps. Actually, they don't disappear; they just don't get moved or dragged! Note the function "isClicked". The problem with my patch is right there.

I don't know if this is a Java bug. The fixes I made are all logical fixes (to do with logic). In short, it indicates that the problem isn't at a lower (API) level, but at a higher (programmer) level.

Thanks for testing!

I didn't test if the patch works for Java L&F. Can you check if I broke things for the Java L&F?

Brent Easton wrote:There appears to be a difference between the Java and Windows LaF's in the sequence of Mouse events generated when you cancel a popup window by clicking away from it.

Now, this would most likely be an API error. Is there a tracker for this, so I can observe this difference? Currently, I've added codes to work around this problem. I merely used the right-click pressed to "cancel drag" (on second thought, you might wanna change this logic to "buttonPressed != BUTTON1" instead, so that anything other than left-click press will cancel drag).
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: 3.2 roundup

Postby Brent Easton » November 3rd, 2011, 7:40 am

Your new patch generates a NullPointerException when moving a counter from 1 map to another.

As I said, this code works perfectly With Java L&F and breaks with Windows L&F. We shouldn't have to do anything. I think your fixes are just attempting to work around this bug.
User avatar
Brent Easton
 
Posts: 2621
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: 3.2 roundup

Postby viewofheaven » November 3rd, 2011, 7:56 am

Brent Easton wrote:Your new patch generates a NullPointerException when moving a counter from 1 map to another.

As I said, this code works perfectly With Java L&F and breaks with Windows L&F. We shouldn't have to do anything. I think your fixes are just attempting to work around this bug.

Erm. Is it alright if you give me a little support, say in terms of testing my patches, instead of telling me I shouldn't have to do anything? Well, if I'm breaking things, please do tell me to stop. But otherwise, is it alright for the team to allow me some indulgence in fixing things? :-)

I don't see that NullPointerException. Check out trunk version 7945, apply my patches, and test. Thanks!
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: 3.2 roundup

Postby Brent Easton » November 3rd, 2011, 8:10 am

Since we have other issues with the Windows L&F, we are considering reverting to the Java L&F, which will fix this issue also, hence my comments. Please, keep at it. I will have a look at the latest version.

Regards,
Brent.
User avatar
Brent Easton
 
Posts: 2621
Joined: December 21st, 2007, 3:06 am
Location: Berry, NSW, Australia

Re: 3.2 roundup

Postby mroyer » November 4th, 2011, 1:18 pm

Forgive my naivety, but what does Windows L&F bring to the table and what do we lose without it?

-Mark R.
mroyer
 
Posts: 166
Joined: March 4th, 2011, 5:06 pm
Location: Massachusetts

Re: 3.2 roundup

Postby mroyer » November 4th, 2011, 1:20 pm

mroyer wrote:Forgive my naivety, but what does Windows L&F bring to the table and what do we lose without it?

-Mark R.



Oh... just looked it up... Look and Feel :oops:
Wouldn't bother me if it were gone.... (not that my opinion matters :wink: ).

-Mark R.
mroyer
 
Posts: 166
Joined: March 4th, 2011, 5:06 pm
Location: Massachusetts

Re: 3.2 roundup

Postby viewofheaven » November 4th, 2011, 2:31 pm

mroyer wrote:
mroyer wrote:Forgive my naivety, but what does Windows L&F bring to the table and what do we lose without it?

Oh... just looked it up... Look and Feel :oops:
Wouldn't bother me if it were gone.... (not that my opinion matters :wink: ).

No problem. Brent and I fixed it just now. Should be in v3.2. Along same lines, we probably would standardize all LookAndFeel(s) soon, so that we have less number of "variant UI environments" to handle. Enjoy! :)
viewofheaven
 
Posts: 80
Joined: October 14th, 2011, 6:24 am

Re: 3.2 roundup

Postby Rindis » November 4th, 2011, 4:53 pm

Okay, I just looked it up too. I hadn't realized that the "Windows Look & Feel" was just a bunch of alternate Java components rather than actually tapping into a library of Windows graphical elements. The examples given on Oracle's site don't look much like Windows to me... (which would seem to be the point of the entire exercise).
User avatar
Rindis
 
Posts: 161
Joined: December 22nd, 2007, 12:49 am

Re: 3.2 roundup

Postby uckelman » November 7th, 2011, 10:08 pm

I've uploaded build 8003 containing Jon's fix for Bug 4050 to the usual place.
User avatar
uckelman
Site Admin
 
Posts: 7139
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: [messages] [Developers] Re: 3.2 roundup

Postby uckelman » November 10th, 2011, 10:19 pm

Thus spake mroyer:
> Brent Easton acknowledged reproducing this behavior. I don't know if he
> intends to fix it for 3.2. I'd rate the issue as low-priority, though
> it can be annoying at times. (I originally reported this here:
> viewtopic.php?f=5&t=4499&start=30[1] )
>

Do you still experience this problem with the svn8015 build?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 7139
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: [messages] [Developers] Re: 3.2 roundup

Postby mroyer » November 11th, 2011, 8:31 pm

uckelman wrote:Thus spake mroyer:
> Brent Easton acknowledged reproducing this behavior. I don't know if he
> intends to fix it for 3.2. I'd rate the issue as low-priority, though
> it can be annoying at times. (I originally reported this here:
> viewtopic.php?f=5&t=4499&start=30[1] )
>

Do you still experience this problem with the svn8015 build?

--
J.


We haven't tried yet. I will try tonight.

-Mark R.
mroyer
 
Posts: 166
Joined: March 4th, 2011, 5:06 pm
Location: Massachusetts

Re: 3.2 roundup

Postby mroyer » November 12th, 2011, 12:04 pm

VASSAL-3.2.0-svn8015-windows.exe appears to be broken.
On initial module launch, at the splash screen, I get the "Eeek! A Bug!" dialog. If I continue on past that, the module loads, but the hex-grids are neither displayed nor enabled on the map.

On the plus-side, bug 4050 seems to have been fixed.
mroyer
 
Posts: 166
Joined: March 4th, 2011, 5:06 pm
Location: Massachusetts

Re: [messages] [Developers] Re: 3.2 roundup

Postby uckelman » November 12th, 2011, 2:45 pm

Thus spake mroyer:
> VASSAL-3.2.0-svn8015-windows.exe appears to be broken.
> On initial module launch, at the splash screen, I get the "Eeek! A Bug!"
> dialog. If I continue on past that, the module loads, but the hex-grids
> are neither displayed nor enabled on the map.

With what module?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 7139
Joined: December 10th, 2007, 9:48 am
Location: Heidelberg, DE

Re: 3.2 roundup

Postby DrNostromo » November 12th, 2011, 2:54 pm

This may be related to the grid problems as I updated to svn8015 yesterday with no problems on my current build of To Be King. I'm not using a grid ...I'm using strictly zones and a few region points.
Dr_Nostromo
Creator - To Be King, Trivial Wars, WWIV
Dr Nostromo's Place
Dr Nostromo's Forum
User avatar
DrNostromo
 
Posts: 836
Joined: December 21st, 2007, 3:54 am
Location: Wine Country, Cal. USA

Re: 3.2 roundup

Postby Flaney » November 13th, 2011, 7:25 am

Same issue.
VASSAL-3.2.0-svn8015-windows.exe appears to be broken.
On initial module launch, at the splash screen, I get the "Eeek! A Bug!" dialog. If I continue on past that, the module loads, but the hex-grids are neither displayed nor enabled on the map.


I am building my own module Babylon5-CGS. I have reverted back to previous build.
Flaney
 
Posts: 92
Joined: March 18th, 2011, 9:11 am

PreviousNext

Return to Developers

Who is online

Users browsing this forum: No registered users and 1 guest