Create account / Log in

Text Label background transparency not saving

Talk about module design ideas and techniques.

Moderators: uckelman, Tim M

Text Label background transparency not saving

Postby jestew » August 20th, 2020, 8:15 am

Hi,

Tested in 3.2.17 and 3.3.3-beta1

Create a text label, set text color to white, background color to black and transparency/alpha to 20%, save text label. Re-open text label and the colors have been saved but not the transparency.

Tried with RGB/CMYK/HSV/HSL and no difference.

I've searched the archives and this doesn't show up as a known limitation.

Any suggested work-arounds? Cheers! jas...
User avatar
jestew
 
Posts: 49
Joined: April 5th, 2009, 6:50 pm

Re: Text Label background transparency not saving

Postby jrwatts » August 20th, 2020, 9:31 am

Seeing as this is the third time this bug has been reported in the last couple of weeks (and no developers have responded to any of them), I decided to finally figure how to file a bug report in Bugzilla. Here it is: http://www.vassalengine.org/tracker/sho ... i?id=13307
jrwatts
 
Posts: 125
Joined: April 29th, 2020, 10:30 pm

Re: Text Label background transparency not saving

Postby jestew » September 9th, 2020, 12:59 pm

Thought I had updated this thread - guess I didn't. I've added the code for the fix into the bug report on the tracker. I just need to set up a pull request and it will be added...
User avatar
jestew
 
Posts: 49
Joined: April 5th, 2009, 6:50 pm

Re: Text Label background transparency not saving

Postby jestew » September 9th, 2020, 2:31 pm

added the pull request... I'll update this thread once it get's included
User avatar
jestew
 
Posts: 49
Joined: April 5th, 2009, 6:50 pm

Re: Text Label background transparency not saving

Postby jestew » September 9th, 2020, 8:16 pm

bada bing,bada boom... It's in. See it live in 3.3.4? Or git clone now...
User avatar
jestew
 
Posts: 49
Joined: April 5th, 2009, 6:50 pm

Re: Text Label background transparency not saving

Postby m3tan » September 17th, 2020, 2:13 am

The didn't make the 3.4.2 release. Is there a plan to roll this out at some point?
User avatar
m3tan
 
Posts: 209
Joined: August 12th, 2018, 11:49 pm

Re: Text Label background transparency not saving

Postby Cattlesquat » September 17th, 2020, 2:44 am

I think jestew's PR got merged into "master", which means it will appear in 3.5

The 3.4 releases are now all bugfixes. The next "feature release" will be 3.5. STAY TUNED FOR THE AWESOME!!!

Also (and relevantly!) I updated the "Roadmap" page in the wiki ... http://www.vassalengine.org/wiki/Roadmap
User avatar
Cattlesquat
 
Posts: 942
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Text Label background transparency not saving

Postby m3tan » September 17th, 2020, 5:57 am

Technically it is a bug, but I know what you meant - bugs from recently introduced features that have broken existing modules. This bug is so old that it's not affecting anybody because it probably never worked...
User avatar
m3tan
 
Posts: 209
Joined: August 12th, 2018, 11:49 pm

Re: Text Label background transparency not saving

Postby uckelman » September 17th, 2020, 12:09 pm

Thus spake m3tan:
> The didn't make the 3.4.2 release. Is there a plan to roll this out at
> some point?

I had intended for this to be merged to the release-3.4.2 branch, but
instead I merged it to master. Since it looks like we will be having
a 3.4.3, I'll make sure this gets into 3.4.3.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8985
Joined: December 10th, 2007, 9:48 am
Location: Durham, England


Return to Module Design

Who is online

Users browsing this forum: No registered users and 5 guests