3.2 Build - Other Bugs Found

Thus spake mroyer:

Brent,
How do I access your builds (Brent-3.2@7886)? I only know how to get
at uckelman’s; I’ve been doing that by going to URL
vassalengine.org/~uckelman/builds/[1].

The short answer is: They don’t exist.

I upload those builds manually. For some time now I’ve been meaning to
set up something on the server which creates builds whenever commits are
made, but it hasn’t come to the top of my list yet.


J.

Thus spake Brent Easton:

Thanks for finding this.
I have reproduced the problem, and a fix for this problem ‘Bug 3998 -
Layer changes not transmitted to other players’ has been committed to
branch Brent-3.2@7886. The Layer trait was substantially reworked to
enable Named KeyStrokes and this broke the Command transmission.
Regards,
Brent.

Merged to trunk@7889. 3.2.0-svn7890 uploaded.


J.

Okay, I think we’ve nailed down a repeatable sequence of events to reliably recreate the issue:

Select a piece with left-click
Right click piece to bring up drop-down menu
Don’t select anything on menu - instead, left-click elsewhere on the game board
The piece jumps to the position pointed to with the left-click

We are using the VASSAL-3.2.0-svn7890-windows.exe build and are playing online. I haven’t tried it off line yet, but I expect it will happen there as well and is not related to being online.

-Mark R.

Hi Mark,

I can’t reproduce anything like this. When I left-click on the board after right-clicking on a counter, the drop-down menu just dissappears and the counter does not move.

Which module are you using? I don’t see how it can be module related, but in case it is, I’d like to try the module you are using.

Regards,
Brent.

BTW, can you verify that this latest build fixes the Layer change not being sent bug?
Thx.

Yes Brent, it it fixed. Sorry - should have mentioned :blush:
Thanks for that.

One of my own concoction. It’s big, just over 31 MB.
dl.dropbox.com/u/24119799/WAA%20-%20Global

Note that you MUST left-click to select the counter first, then right click to bring up the menu, then left-click else where, exactly in that order (at least for me in my module). Just right clicking on the counter doesn’t do it.

BTW, I also verified the behavior occurs offline too.

Thanks Brent,
-Mark R.

Thanks Mark,
Have reproduced this now. It happens to all counters in all modules in 3.2. Bug 4050 - Counters move unexpectedly.
Working on it tomorrow. A bug a day keeps beta on the way.
Rgds,
Brent.

lol…
Thanks Brent. It’s no rush to fix from our point of view. Now that we understand the issue, we’ll just be careful not to do it by accident.

-Mark R.

New bug - svn7908

When setting up Game Piece Layers on a map, everything is fine when adding new layers. However, if you attempt to Insert a new layer in between existing layers, you get an Eeeek. Here’s the error log:

2011-10-14 09:41:25,130 [0-main] INFO VASSAL.launch.StartUp - Starting
2011-10-14 09:41:25,146 [0-main] INFO VASSAL.launch.StartUp - OS Windows XP
2011-10-14 09:41:25,146 [0-main] INFO VASSAL.launch.StartUp - Java version 1.6.0_26
2011-10-14 09:41:25,146 [0-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.0-svn7908
2011-10-14 09:41:25,208 [0-AWT-EventQueue-0] INFO VASSAL.launch.ModuleManager - Manager
2011-10-14 09:41:34,880 [0-SwingWorker-pool-6964063-thread-1] INFO VASSAL.launch.AbstractLaunchAction - Loading module file C:\Games\VassalFiles\TBK_New\Mod\TBK_0.99.vmod
2011-10-14 09:41:34,990 [0-SwingWorker-pool-6964063-thread-1] INFO VASSAL.launch.TilingHandler - No images to tile.
2011-10-14 09:41:34,990 [0-SwingWorker-pool-6964063-thread-1] INFO VASSAL.launch.AbstractLaunchAction - Loading module To Be King
2011-10-14 09:41:35,005 [0-SwingWorker-pool-6964063-thread-1] INFO VASSAL.tools.io.ProcessLauncher - launching C:\Utilities\Java6u22\bin\java -Xms256M -Xmx512M -DVASSAL.id=1 -DVASSAL.port=4570 -Duser.home=C:\Documents and Settings\Rich -cp lib\Vengine.jar VASSAL.launch.Player --load – C:\Games\VassalFiles\TBK_New\Mod\TBK_0.99.vmod
2011-10-14 09:41:35,865 [1-main] INFO VASSAL.launch.StartUp - Starting
2011-10-14 09:41:35,880 [1-main] INFO VASSAL.launch.StartUp - OS Windows XP
2011-10-14 09:41:35,880 [1-main] INFO VASSAL.launch.StartUp - Java version 1.6.0_26
2011-10-14 09:41:35,880 [1-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.0-svn7908
2011-10-14 09:41:35,880 [1-main] INFO VASSAL.launch.Launcher - Player
2011-10-14 09:41:37,661 [1-AWT-EventQueue-0] WARN VASSAL.tools.ErrorDialog - Image not found: Splash.png
2011-10-14 09:41:38,552 [1-AWT-EventQueue-0] WARN VASSAL.launch.BasicModule - To Be King version 0.99_A0022
2011-10-14 09:41:42,708 [1-AWT-EventQueue-0] INFO VASSAL.build.GameModule - Exiting
2011-10-14 09:41:43,521 [0-IPC receiver for 32879825] ERROR VASSAL.tools.ipc.IPCMessageReceiver -
java.net.SocketException: Connection reset
at java.net.SocketInputStream.read(Unknown Source) ~[na:1.6.0_26]
at java.net.SocketInputStream.read(Unknown Source) ~[na:1.6.0_26]
at java.io.ObjectInputStream$PeekInputStream.peek(Unknown Source) ~[na:1.6.0_26]
at java.io.ObjectInputStream$BlockDataInputStream.peek(Unknown Source) ~[na:1.6.0_26]
at java.io.ObjectInputStream$BlockDataInputStream.peekByte(Unknown Source) ~[na:1.6.0_26]
at java.io.ObjectInputStream.readObject0(Unknown Source) ~[na:1.6.0_26]
at java.io.ObjectInputStream.readObject(Unknown Source) ~[na:1.6.0_26]
at VASSAL.tools.ipc.IPCMessageReceiver.run(IPCMessageReceiver.java:34) ~[Vengine.jar:na]
at java.lang.Thread.run(Unknown Source) [na:1.6.0_26]
2011-10-14 09:41:45,349 [0-SwingWorker-pool-6964063-thread-2] INFO VASSAL.launch.AbstractLaunchAction - Loading module file C:\Games\VassalFiles\TBK_New\Mod\TBK_0.99.vmod
2011-10-14 09:41:45,427 [0-SwingWorker-pool-6964063-thread-2] INFO VASSAL.launch.TilingHandler - No images to tile.
2011-10-14 09:41:45,427 [0-SwingWorker-pool-6964063-thread-2] INFO VASSAL.launch.AbstractLaunchAction - Loading module To Be King
2011-10-14 09:41:45,443 [0-SwingWorker-pool-6964063-thread-2] INFO VASSAL.tools.io.ProcessLauncher - launching C:\Utilities\Java6u22\bin\java -Xms256M -Xmx512M -DVASSAL.id=3 -DVASSAL.port=4572 -Duser.home=C:\Documents and Settings\Rich -cp lib\Vengine.jar VASSAL.launch.Editor --edit – C:\Games\VassalFiles\TBK_New\Mod\TBK_0.99.vmod
2011-10-14 09:41:46,318 [3-main] INFO VASSAL.launch.StartUp - Starting
2011-10-14 09:41:46,318 [3-main] INFO VASSAL.launch.StartUp - OS Windows XP
2011-10-14 09:41:46,318 [3-main] INFO VASSAL.launch.StartUp - Java version 1.6.0_26
2011-10-14 09:41:46,318 [3-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.0-svn7908
2011-10-14 09:41:46,318 [3-main] INFO VASSAL.launch.Launcher - Editor
2011-10-14 09:41:48,083 [3-AWT-EventQueue-0] WARN VASSAL.tools.ErrorDialog - Image not found: Splash.png
2011-10-14 09:41:48,958 [3-AWT-EventQueue-0] WARN VASSAL.launch.BasicModule - To Be King version 0.99_A0022
2011-10-14 09:42:00,943 [3-AWT-EventQueue-0] ERROR VASSAL.tools.ErrorDialog -
java.lang.ArrayIndexOutOfBoundsException: null
at java.lang.System.arraycopy(Native Method) ~[na:1.6.0_26]
at VASSAL.tools.ArrayUtils.insert(ArrayUtils.java:524) ~[Vengine.jar:na]
at VASSAL.tools.ArrayUtils.insert(ArrayUtils.java:514) ~[Vengine.jar:na]
at VASSAL.configure.StringArrayConfigurer$2.actionPerformed(StringArrayConfigurer.java:117) ~[Vengine.jar:na]
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source) ~[na:1.6.0_26]
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source) ~[na:1.6.0_26]
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source) ~[na:1.6.0_26]
at javax.swing.DefaultButtonModel.setPressed(Unknown Source) ~[na:1.6.0_26]
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source) ~[na:1.6.0_26]
at java.awt.Component.processMouseEvent(Unknown Source) ~[na:1.6.0_26]
at javax.swing.JComponent.processMouseEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.Component.processEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.Container.processEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.Component.dispatchEventImpl(Unknown Source) ~[na:1.6.0_26]
at java.awt.Container.dispatchEventImpl(Unknown Source) ~[na:1.6.0_26]
at java.awt.Component.dispatchEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.Container.dispatchEventImpl(Unknown Source) ~[na:1.6.0_26]
at java.awt.Window.dispatchEventImpl(Unknown Source) ~[na:1.6.0_26]
at java.awt.Component.dispatchEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue.dispatchEventImpl(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue.access$000(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue$1.run(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue$1.run(Unknown Source) ~[na:1.6.0_26]
at java.security.AccessController.doPrivileged(Native Method) ~[na:1.6.0_26]
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source) ~[na:1.6.0_26]
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue$2.run(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue$2.run(Unknown Source) ~[na:1.6.0_26]
at java.security.AccessController.doPrivileged(Native Method) ~[na:1.6.0_26]
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventQueue.dispatchEvent(Unknown Source) ~[na:1.6.0_26]
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) [na:1.6.0_26]
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) [na:1.6.0_26]
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) [na:1.6.0_26]
at java.awt.EventDispatchThread.pumpEvents(Unknown Source) [na:1.6.0_26]
at java.awt.EventDispatchThread.pumpEvents(Unknown Source) [na:1.6.0_26]
at java.awt.EventDispatchThread.run(Unknown Source) [na:1.6.0_26]

GamePiece Layers bug fixed - will be in next build.

Attached is a sample mod (just change .zip to .vmod). This mod was created in svn7908.

The button will retrieve a Lock from a Deck. When the Lock hits the map, a map trigger sets a dynamic property called LockCode that will generate a number from 1 to 6 and there’s a layer trait that displays this code. A player attempting to open a lock would need a key with the same code.

Players are not supposed to know what the code is until they attempt to open it. But, regardless of where I place the Mask trait in the trait order, it still displays the LockCode. I don’t want it displayed until the player attempts to open the lock.

Is this a bug or am I doing something wrong?

Were you able to get this one sorted?

I forgot about this one as I began working on other aspects of the game. I’ll test it out in the morning and let you know.

3.2 svn8015

I’ve loaded and re-saved the sample mod attached (change zip to vmod).

Same problem. Regardless of where I put the Mask trait, I can’t get the lock code number to hide.

It would probably help if you set the card in the locks deck so it starts Face-down. Because it starts face up, it will draw face up. The “draw new cards face up” selection only matters if they are face down.

You may also want to change your base image to be different from your mask image so you can decipher if you are really looking at the mask or are looking at the base - I couldn’t figure it out until I changed the base

That was an oversight on my part in the sample but I still couldn’t get it to work. After I fooled around with it, I realized that I needed to put the layer that displays the number above the Mask and the Dynamic Property that controls it below the Mask. I’m used to putting Dynamic Properties at the top so I hadn’t tried that trait order before. It’s working now.

I did notice a strange glitch while I was fooling with this, though. At one point, I changed the standard CTRL M for the Mask command to a keyword. Then later, I changed the keyword back to CTRL M and it wouldn’t work. I had to remove the Mask trait and start a new one before I could get a key command to work again.

Thus spake DrNostromo:

I did notice a strange glitch while I was fooling with this, though. At
one point, I changed the standard CTRL M for the Mask command to a
keyword. Then later, I changed the keyword back to CTRL M and it
wouldn’t work. I had to remove the Mask trait and start a new one before
I could get a key command would work again.

Is this reproducible?


J.

Thus spake DrNostromo:

I did notice a strange glitch while I was fooling with this, though. At
one point, I changed the standard CTRL M for the Mask command to a
keyword. Then later, I changed the keyword back to CTRL M and it
wouldn’t work. I had to remove the Mask trait and start a new one before
I could get a key command would work again.

Is this reproducible with svn8080?


J.

I have no problem changing a Mask command now so that seems to be ok.