2815: ArrayIndexOutOfBoundsException in Stack.insertPieceAt()
2798: ConcurrentModificationException in PrefsEditor.save()
2715: NPE in Map.setup()
Notes:
George found 4126 a few days ago. We weren’t removing drag listeners in PieceMover when drags ended, which leads to listeners accumulating. After a thousand drags, this becomes a significant performance issue. I’m a little surprised that nobody noticed this before.
2815 and 2798 are second attempts at fixing their respective problems.
I’ve uploaded 3.1.18-svn8020 as a release candidate for 3.1.18:
Tried this somewhat briefly on my iMac (8GB, 3GHz Core 2 duo).
It performs quite snappily. I ran some large modules with big maps (such as DAK-II).
Startup and loading are quite fast. There is some noticeable flashing during initial scrolling of the map as tiles load, but once an area has been visited, scrolling is smooth and quick.
I did not notice any particular issues, in particular the concurrent modification error did not appear for me, as it has sometimes in the past. It may be more of an issue on a slower machine, though. If I have time I’ll try to test on one of those as well.
I did notice the tool bar button problem with the “Three Battles of Manassas” module ( vassalengine.org/wiki/Module … f_Manassas ) for the first appearance of the loss charts. These are selected as boards in the initial dialog and appear in response to tool bar buttons. The resulting windows do not show the tool bar buttons until after a resize.
Steps to reproduce:
Start new game
Select setup: “All Maps”
Select board “Bury These Poor Men Confederate Loss Chart”
Select board “Bury These Poor Men Union Loss Chart”
Open map window with button “Confederate Losses”
Note that there are no tool bar buttons.
Resize the map window
Tool bar buttons appear
Java information:
Newfoundland:~] tar% /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/bin/java -version
java version “1.6.0_29”
Java™ SE Runtime Environment (build 1.6.0_29-b11-402-10M3527)
Java HotSpot™ 64-Bit Server VM (build 20.4-b02-402, mixed mode)
Trace information:
22 Nov 2011 06:01:18.045 0 – Starting
22 Nov 2011 06:01:18.047 0 – OS Mac OS X
22 Nov 2011 06:01:18.047 0 – Java version 1.6.0_29
22 Nov 2011 06:01:18.047 0 – VASSAL version 3.1.18-svn8020
…
22 Nov 2011 06:20:44.987 0 – Loading module file /Users/tar/Documents/Games/Vassal/Three-Battles-of-Manassas-v0.5.vmod
22 Nov 2011 06:20:44.990 0 – Loading module Three Battles of Manassas
22 Nov 2011 06:20:44.990 0 /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/bin/java -Xms256M -Xmx512M -DVASSAL.id=9 -Duser.home=/Users/tar -cp /Applications/VASSAL-3.1.18-svn8020.app/Contents/Resources/Java/Vengine.jar -Xdock:name=Three Battles of Manassas -Xdock:icon=/Applications/VASSAL-3.1.18-svn8020.app/Contents/Resources/VASSAL.icns -Dapple.awt.graphics.UseQuartz=true VASSAL.launch.Player
22 Nov 2011 06:20:47.585 9 – Three Battles of Manassas version 0.5
22 Nov 2011 06:20:47.585 9
22 Nov 2011 06:23:26.244 9 – Exiting
I did not notice any particular issues, in particular the concurrent
modification error did not appear for me, as it has sometimes in the
past. It may be more of an issue on a slower machine, though. If I have
time I’ll try to test on one of those as well.
This could be by design, since 3.1.18 contains a fix for that.
I did notice the tool bar button problem with the “Three Battles of
Manassas” module ( vassalengine.org/wiki/Module …
f_Manassas[1] ) for the first appearance of the loss charts. These are
selected as boards in the initial dialog and appear in response to tool
bar buttons. The resulting windows do not show the tool bar buttons
until after a resize.
Steps to reproduce:
Start new game
Select setup: “All Maps”
Select board “Bury These Poor Men Confederate Loss Chart”
Select board “Bury These Poor Men Union Loss Chart”
I did not notice any particular issues, in particular the concurrent
modification error did not appear for me, as it has sometimes in the
past. It may be more of an issue on a slower machine, though. If I
have time I’ll try to test on one of those as well.
This could be by design, since 3.1.18 contains a fix for that.
I did notice the tool bar button problem with the “Three Battles of
Manassas” module ( vassalengine.org/wiki/Module …
f_Manassas[1] ) for the first appearance of the loss charts. These
are selected as boards in the initial dialog and appear in response to
tool bar buttons. The resulting windows do not show the tool bar
buttons until after a resize.
Steps to reproduce:
Start new game
Select setup: “All Maps”
Select board “Bury These Poor Men Confederate Loss Chart”
Select board “Bury These Poor Men Union Loss Chart”
Nobody’s objected yet to the test build for 3.1.18 (though I realize this is Thanksgiving in the US, so some people are probably in a turkey-induced stupor at present). Thanks, tar, for testing this on MacOS. If nobody objects by Saturday evening, I’m going to release this build as 3.1.18.
