Create account / Log in

Delete reporting broken in recent Vassal versions

Issues with the Vassal engine.

Moderators: uckelman, Tim M

Delete reporting broken in recent Vassal versions

Postby Rindis » September 25th, 2014, 6:26 am

I'm sure the issue's a bit different than that, but that's what I've got at the moment.

I've been going crazy trying to get a new module, with some fancy footwork, to properly report delete actions. I just noticed that an old module, where it worked, now has the same problem....

The Federation & Empire module (available through a link provided on the module page in the wiki) reports most actions taken. When deleting a unit, it reports something like "* DN deleted in 0902". In 3.2.13 this turns into "* DN deleted in", with the location missing. Other reports, such as creation, moving and cloning work fine.

Going through my personal collection of Vassal installers shows this cropped up between 3.2.6 (where it works) and 3.2.7 (where it doesn't).

http://www.starfleetgames.com/documents/F&E%201.3.1.zip
User avatar
Rindis
 
Posts: 198
Joined: December 22nd, 2007, 12:49 am

Re: Delete reporting broken in recent Vassal versions

Postby JoelCFC25 » September 25th, 2014, 2:04 pm

I believe this is related to the fix for bug 10211. Can you verify what location property is being used in your Report Action traits?
JoelCFC25
 
Posts: 727
Joined: October 12th, 2010, 5:15 pm
Location: Minnetrista, MN

Re: Delete reporting broken in recent Vassal versions

Postby Rindis » September 25th, 2014, 4:09 pm

The original module uses $oldLocation$, but I tried a few other things while flailing around.
User avatar
Rindis
 
Posts: 198
Joined: December 22nd, 2007, 12:49 am

Re: Delete reporting broken in recent Vassal versions

Postby posh1227 » November 20th, 2014, 1:38 pm

This appears to still be a problem for me. Even with 3.2.13. $location$ is always blank for a delete report action which I assume is the expected result. However $oldLocation$ is wrong. By that I mean. If the piece has never moved it's blank. Otherwise oldLocation reports the location previous to where it was deleted from.

I'll post what I'm seeing here (this is an existing module written by others that I have been modifying).

Here's the Module https://www.dropbox.com/s/9bbin6kr551httn/UKC_v2.1.1_FOW.vmod?dl=0

Here's a log showing the issue https://www.dropbox.com/s/zv47lc2ph5ykx9s/UKC_Delete-ReportActionIssue.vlog?dl=0

I'd appreciate any help I can get.
posh1227
 
Posts: 2
Joined: November 20th, 2014, 1:23 pm

Re: Delete reporting broken in recent Vassal versions

Postby posh1227 » November 20th, 2014, 1:51 pm

Here's most of the log for those that would rather not download it. The report action is on the Marker prototype.

Code: Select all
<Jason> - the report action is set to show $oldLocation$
<Jason> - Let's just delete a PC Marker to start
* Royalist PC Marker removed at
<Jason> - No location listed
<Jason> - now lets move one first before we delete it
* Royalist PC Marker moves from Corbridge to Carlisle
* Royalist PC Marker removed at Corbridge
<Jason> - Notice how it lists the original location.  Now where it was deleted from.
<Jason> - Let's move one 2 spaces
* Royalist PC Marker moves from Durham to Kendal
* Royalist PC Marker moves from Kendal to Egremont
* Royalist PC Marker removed at Kendal
<Jason> - As you can see oldLocation is one space behind
posh1227
 
Posts: 2
Joined: November 20th, 2014, 1:23 pm

Re: Delete reporting broken in recent Vassal versions

Postby uckelman » December 14th, 2014, 10:15 pm

Would you create a minimal example module showing the problem?
User avatar
uckelman
Site Admin
 
Posts: 8839
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Delete reporting broken in recent Vassal versions

Postby Rindis » February 21st, 2015, 3:06 am

uckelman wrote:Would you create a minimal example module showing the problem?

Here you go.

1) Start module
2) Start game
3) Put a piece on the board
4) *Move* piece
5) Delete piece
Attachments
OldLocaction Ex.vmod
(3.31 KiB) Downloaded 171 times
User avatar
Rindis
 
Posts: 198
Joined: December 22nd, 2007, 12:49 am

Re: Delete reporting broken in recent Vassal versions

Postby Rindis » December 12th, 2015, 10:06 pm

Any chance of seeing this worked on?

I just did some fiddling around, and I can't find any variable that will cause proper reporting on delete. Everything else is fine, like reporting a clone, or even having that variable display in a text label. But a delete action reports one step behind.
User avatar
Rindis
 
Posts: 198
Joined: December 22nd, 2007, 12:49 am

Re: Delete reporting broken in recent Vassal versions

Postby uckelman » December 12th, 2015, 11:04 pm

Thus spake Rindis:
> Any chance of seeing this worked on?

I'm not working on VASSAL at all until we've moved to our new house.
(End of January?) I'll have a look at the test case then, but if the
solution turns out to be complicated, be prepared for me to say that
I won't work on a fix for it in 3.2. I intend to spend all of my
development time in the new year on VASSAL 4.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8839
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Delete reporting broken in recent Vassal versions

Postby Tim M » December 13th, 2015, 4:14 am

new house? wait after all that work! Damn! ok scoop plz (offline) or at least say im in black :)
Tim,
Vassal Uber Geek/Guru

Problems? post your OS, Physical Mem, version of Vassal and Java plus the Module in question.
No developer can help with out that info, thx!
User avatar
Tim M
 
Posts: 1816
Joined: December 8th, 2007, 12:22 pm
Location: Earth

Re: Delete reporting broken in recent Vassal versions

Postby uckelman » December 13th, 2015, 7:03 pm

Thus spake Tim M:
> new house? wait after all that work! Damn! ok scoop plz (offline) or at
> least say im in black :)

The new house is the one I've been working on all this time.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8839
Joined: December 10th, 2007, 9:48 am
Location: Durham, England


Return to Technical Support & Bugs

Who is online

Users browsing this forum: Google [Bot] and 5 guests