Create account / Log in

Vassal 3.2.15 not capturing shuffle in log file.

Issues with the Vassal engine.

Moderators: Tim M, uckelman

Vassal 3.2.15 not capturing shuffle in log file.

Postby keysb » January 5th, 2016, 1:35 pm

Computers:
- Home built PC ( win 8.1 Pro, intel i7-490k )
- Java 7 Update 67

- Microsoft Surface 3 (win 10)
- Java 8 Update 65

-VM on Imac
- Java Java 7 Update unknown

VASSAL 3.2.15
Modules: (problem occurs in all these modules)
Mage Knight Board Game: The Lost Legion & Krang: version: 1.5.7
Mage Knight Board Game: The Lost Legion & Krang: version: 1.6.6
Mage Knight Board Game: The Lost Legion & Krang: version:1.6.7
Mage Knight Board Game: BG: LL, K & SoT: version: 0.5
Mage Knight Board Game: BG: LL, K & SoT: version: 0.6

Test module to show problem:
Mage Knight Board Game: The Lost Legion & Krang: version: test
test8.vmod
Mage Knight Board Game: The Lost Legion & Krang: version: test
(160.3 KiB) Downloaded 315 times


Sample logs: (generated with Vassal version in file name, and with the attached "Test" module)

vassal 3.2.13 first log Version test.vlog
vassal 3.2.13 first log Version test.vlog
(1.35 KiB) Downloaded 277 times

vassal 3.2.15 first log Version test.vlog
vassal 3.2.15 first log Version test.vlog
(1.33 KiB) Downloaded 307 times


I have a working log with 3.2.12 if needed
The button "Shuffle decks" caused a crash in 3.2.14.

In Brief:
Vassal version 3.2.15 does not save shuffled data in it's vlog files.
Start logging
Shuffle the Deck
End the log.
close vassal
Open the log file.
Play though the log, deck remain un-shuffled.

In Detail:
This issue seems to have appeared sometime after Vassal 3.2.13
I've created an attached a module with a single deck cards in the deck are numbered 1 though six and appear in sequence, clicking shuffle will randomise them. This works correctly in Vassal versions 3.2.12, 3.2.13 and 3.2.15, however 3.2.14 crashes. The problem occurs when opening and playing though a previously saved log file created with vassal version 3.2.15 with a shuffle action. 3.2.15 will correctly play though log files created with earlier versions.

It appears that Vassal 3.2.15 is not adding the Shuffled deck, or the shuffle action of the deck, into the log. This behaviour can be seen in the two logs provided.
Log file "Vassal 3.2.13 first log Version test.vlog" shows the shuffle being completed and the deck is shuffled.
Log file "Vassal 3.2.15 first log Version test.vlog" shows the shuffle being completed and however the deck remains un-shuffled.
keysb
 
Posts: 4
Joined: January 5th, 2016, 12:56 pm

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby barbanera » January 6th, 2016, 4:44 pm

This seems to be the same bug I reported almost one year ago:
http://www.vassalengine.org/forum/viewtopic.php?f=3&t=7976

I am just using 3.2.13 till it gets fixed, if ever.
barbanera
 
Posts: 377
Joined: January 12th, 2012, 2:27 pm

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby keysb » January 6th, 2016, 11:36 pm

I downloaded your module and tested it. (Your pictures are much prettier than mine)

I encountered an additional problem, to create a log vassal seems to need to have at least 1 step, it does not seem to create empty log files even though it reports as having done it. as all your module does is shuffle, (mine records a shuffle comment, the event of the shuffle button being pressed) your test file won't even create a log in 3.2.15 for me unless I also hand enter a comment, and now it does create a log it only has the step for the comment and not the shuffle.

It really is like the shuffle event is not being written to the log. Here's hoping someone fixes it, it seems like a major bug to me.
keysb
 
Posts: 4
Joined: January 5th, 2016, 12:56 pm

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby uckelman » January 11th, 2016, 12:21 am

Thus spake keysb:
> I downloaded your module and tested it. (Your pictures are much prettier
> than mine)
>
> I encountered an additional problem, to create a log vassal seems to
> need to have at least 1 step, it does not seem to create empty log files
> even though it reports as having done it. as all your module does is
> shuffle, (mine records a shuffle comment, the event of the shuffle
> button being pressed) your test file won't even create a log in 3.2.15
> for me unless I also hand enter a comment, and now it does create a log
> it only has the step for the comment and not the shuffle.
>
> It really is like the shuffle event is not being written to the log.
> Here's hoping someone fixes it, it seems like a major bug to me.

Try the 3.2.16-svn9184 build:

http://vassalengine.sourceforge.net/builds/

Does that solve the problem for you?

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8138
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby keysb » January 11th, 2016, 5:47 am

It looks like the problem is resolved in build 3.2.16-svn9184

I'll attach the successful log files here on the chance you want them:

vassal 3.2.16-svn9184 first log Version test.vlog
3.2.16-svn9184 test
(1.39 KiB) Downloaded 264 times

barbanera's test module.vlog
barbanera's module test log
(1.1 KiB) Downloaded 294 times


Thank you for the quick resolution.
keysb
 
Posts: 4
Joined: January 5th, 2016, 12:56 pm

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby uckelman » January 11th, 2016, 1:25 pm

Thus spake keysb:
> It looks like the problem is resolved in build 3.2.16-svn9184

Thanks for testing. I know what commit introduced the problem now, so
this will be fixed in the 3.2.16 release.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 8138
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby uckelman » January 11th, 2016, 11:19 pm

I've noted this as Bug 12522 in our tracker:

http://www.vassalengine.org/tracker/sho ... i?id=12522

Please try 3.2.16-svn9208, available here:

http://vassalengine.sourceforge.net/builds/

and let us know if this fixes the problem for you.
User avatar
uckelman
Site Admin
 
Posts: 8138
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby keysb » January 18th, 2016, 5:52 am

Sorry about the delay did not notice this message.

I've breifly tested this module and it seems to work as well.

I've attached my log file if you want to see it
Attachments
Thrid test log 1.vlog
Another test log
(1.48 KiB) Downloaded 274 times
keysb
 
Posts: 4
Joined: January 5th, 2016, 12:56 pm

Re: Vassal 3.2.15 not capturing shuffle in log file.

Postby uckelman » April 7th, 2016, 12:34 pm

The fix for this problem is in the 3.2.16 release. If you have any further difficulties with this, please let us know.
User avatar
uckelman
Site Admin
 
Posts: 8138
Joined: December 10th, 2007, 9:48 am
Location: Durham, England


Return to Technical Support & Bugs

Who is online

Users browsing this forum: No registered users and 0 guests