Test builds for 3.3.0

How you test if it’s working ?

I launched a module where the card use NonRectangular but works fine for me.

Thus spake burzum51:

How you test if it’s working ?

I launched a module where the card use NonRectangular but works fine
for me.

The code which needs updating will in most cases be in a paint(Graphics)
method of a JComponent subclass. In NonRectangular, that’s going to be
a method of the anonymous JPanel inside the Ed constructor, and the
place where that JComponent is displayed is in the dialog for the
NonRectangular piece trait in the Editor. The way to test that is to
check how that JPanel looks in 3.2.17, check how it looks in the most
recent test build under HiDPI scaling, and then check how it looks after
correcting it for HiDPI scaling.

Most of the remaining classes which need updating will have some
JComponent like that which is displayed in the Editor.


J.

Obscurable is done. (There was nothing to do for that one.)

Zone is done. PolygonEditor didn’t need modification.

HexGridNumbering and SquareGridNumbering are done.

Apologies, I mis-reported my last two bug finds. I forgot to update my platform details as I had changed laptops for these two tests:

  • movement trails don’t appear in C&C Napoleonics Module (update - also don’t appear in C&C Ancients)
  • “take picture” function broke (tested in C&C Napoleonics and C&C Medieval)

The platform used was:
VASSAL version 3.3.0-svn9329 - since checked and still showing on version 3.3.0-svn9335
Platform: MacBook Pro (13-inch, 2016, Two Thunderbolt 3 ports), macOS Catalina 10.15.3

Repeating the tests on my other laptop MacBook Pro (13-inch, Mid 2012), macOS Catalina 10.15.4 does not reproduce either of these problems.

I guess this is Retina-related as the older MacBook Pro is non-retina if I recall correctly.

Mark

Thus spake marktb1961:

Apologies, I mis-reported my last two bug finds. I forgot to update my
platform details as I had changed laptops for these two tests:

  • movement trails don’t appear in C&C Napoleonics Module (update - also
    don’t appear in C&C Ancients)
  • “take picture” function broke (tested in C&C Napoleonics and C&C
    Medieval)

The platform used was:
VASSAL version 3.3.0-svn9329 - since checked and still showing on
version 3.3.0-svn9335
Platform: MacBook Pro (13-inch, 2016, Two Thunderbolt 3 ports), macOS
Catalina 10.15.3

Repeating the tests on my other laptop MacBook Pro (13-inch, Mid 2012),
macOS Catalina 10.15.4 does not reproduce either of these problems.

I guess this is Retina-related as the older MacBook Pro is non-retina if
I recall correctly.

Thanks for clarifying. That’s extremely helpful, since it narrows down
the causes to the HiDPI changes we’ve made.


J.

Hello Joel,
Is there a recommendation on what Java version to use? I am using Windows 1à, the 9335 build and Java 8 and would like to report some issues, but maybe I need 1st to upgrade Java?

In any case my issue is simple. Mapboard graphics look fine in the OCS Tunisia II module 1.06 (vassalengine.org/mediawiki/i … _1_06.vmod)
but there are some Charts and tables windows that display some images containing mostly charts and texts
These images do not seem to be rendered optimally.
As an issue I reported some months ago, this suboptimal rendering appears when I use a 125% DPI scaling ratio on the windows display options. When I scale back to 100% the rendering is ok.
I can send you some images if needed.

Also I started VASL and loaded 1 board. There, when I select a unit in a hex, a red selection box appears somewhere else on the map. Are VASL issues to be reported too?

Thank you for your great work on the engine.

One more thing that occurs when using a DPI scaling different from 100% is that when I scroll the mapboard up or down with my mouse or with the pgUp / pgDown, the refreshing of the map sometimes leaves some horizontal or vertical white lines (maybe 1 dot wide). As soon as I move the mouse pointer there seems to be some further refreshing of the screen and these lines disappear.
When I stop the application, set windows to 100% DPI scaling and start the game again, this does not occur.

Kr
Claudio

Hi,

how can I add to this version a new feature i developped :

vassalengine.org/tracker/sho … gi?id=9381

Do you manage roadmap in bugzilla ?

Regards

Thus spake ClaudioC:

Hello Joel,
Is there a recommendation on what Java version to use? I am using
Windows 1à, the 9335 build and Java 8 and would like to report some
issues, but maybe I need 1st to upgrade Java?

If you’re running a 3.3.0 test build on Windows, you will be using the
version of Java which is bundled with the test build, unless you’ve
specifically taken action to prevent that. Java 13 is what’s bundled
with the test builds.

The version of Java you have installed on your system (or not) won’t
matter from 3.3.0 onward—which was one of the motivtions for preparing
this release in the first place.

In any case my issue is simple. Mapboard graphics look fine in the OCS
Tunisia II module 1.06 (vassalengine.org/mediawiki/i
_1_06.vmod[1])
but there are some Charts and tables windows that display some images
containing mostly charts and texts
These images do not seem to be rendered optimally.
As an issue I reported some months ago, this suboptimal rendering
appears when I use a 125% DPI scaling ratio on the windows display
options. When I scale back to 100% the rendering is ok.
I can send you some images if needed.

Thanks. I’ll have a look at those.

Also I started VASL and loaded 1 board. There, when I select a unit in a
hex, a red selection box appears somewhere else on the map. Are VASL
issues to be reported too?

VASL will have a set of problems specific to it because some of the
classes in VASL are derived from ones I’ve updated in VASSAL for 3.3.0,
but hasn’t been touched yet. There’s not much point in reporting issues
with VASL until someone has had time to update VASL, and I’m not going to
bother the VASL devs with this until we’re mostly sorted out on our end.


J.


messages mailing list
messages@vassalengine.org
vassalengine.org/mailman/listinfo/messages

Thus spake ClaudioC:

but there are some Charts and tables windows that display some images
containing mostly charts and texts
These images do not seem to be rendered optimally.

Try 3.3.0-svn9336 or later.

I updated OpIcon for HiDPI support in 9336, which is what is used by
Chart and HTMLChart for displaying images.

Does that solve the problem you were seeing?


J.

3.3.0-svn9337 adds HiDPI support to GridEditor.

Remaining issues:

  • For HiDPI support:

    RegionGrid
    PropertySheet
    SetupStack
    Visualizer
    WizardSupport

  • An HiDPI image size selection issue which involves all of:

    OpIcon
    IconFamily
    IconConfigurer
    SpecialDiceButton
    anything which uses ImageIcon

  • Running down bugs reported on this thread.

Hello Joel,
Thanks for the clarification abt embedded java version on Windows 10 and VASL being out of scope.

Concerning the 2 issues I reprorted yesterday:
The rendenring of the texts and charts at 150% and 175% DPI scaling in now ok on TunisiaII
However I still see occasional white lines on the mapboard when moving the map around. This time I reproduced the error with right clicks to recenter the map, it also occurs like that. Again, if after it occurs I slightlyreposition the map with the up/down keys, the issue disappears. This occurred at both 150% and 175%

Bye
Claudio

Thus spake ClaudioC:

Concerning the 2 issues I reprorted yesterday:
The rendenring of the texts and charts at 150% and 175% DPI scaling in
now ok on TunisiaII

Good. Thanks for confirming.

However I still see occasional white lines on the mapboard when moving
the map around. This time I reproduced the error with right clicks to
recenter the map, it also occurs like that. Again, if after it occurs I
slightlyreposition the map with the up/down keys, the issue disappears.
This occurred at both 150% and 175%

I wasn’t expecting this to change with the most recent build, as I didn’t
work on this problem. My guess is that it’s due to a rounding error in
the board painter. Would you check whether this happens at 200%? (If I’m
right that the cause is a rounding error, I suspect you won’t see the
problem at 200% because 2 is an integer, whereas 1.5 and 1.75 are not.)


J.

Joel,
I tested at DPI scaling 200 as you suggested and also at scaling 201%
Indeed, the issue appeared at 201% but I did not see it at 200%

Joel, not sure if anyone reported this.
I spotted another thing that occurs with DPI scaling.
The TunisiaII module has the MapWindow Property - “Mouse_over Stack Viewer” with option “Display Text” active and a Summary text above the piece.

When the scaling is not 100% the text is displayed in an incorrect location. I suspect that scaling is not applied because the farther south and east I go on the map the farther away to the north west the text is displayed.

Kr
Claudio

One more issue.
Movement trail lines and ircles are not drawn if the scaling is 125%. They are for scaling 100%.

Hi,

Is there still time to add new features to the 3.3.0 release ?

Is there a plan to make an 3.3.1 ou 3.4 or you will stop here and work on 4.0 (i make to work the current source code and want to konw if there is a point to continu).

Regards,

Thus spake burzum51:

Hi,

Is there still time to add new features to the 3.3.0 release ?

I am reluctant to add new features to the current codebase, as new
features require testing, documentation, and ongoing support. Any
new feature at this point would have to be quite compelling for me
to consider its addition.

Is there a plan to make an 3.3.1 ou 3.4 or you will stop here and work
on 4.0 (i make to work the current source code and want to konw if there
is a point to continu).

My plan has long been and continues to be to shift to V4 when the
current release is out. There might be further 3.3.x releases to fix
bugs introduced in 3.3.0, but I don’t forsee doing more V3 series
releases otherwise.

If you would like to help, why not troubleshoot one of the bugs noted
on this thread? That’s the help we need right now.


J.