Test builds for 3.3.0

Thus spake ClaudioC:

Concerning the 2 issues I reprorted yesterday:
The rendenring of the texts and charts at 150% and 175% DPI scaling in
now ok on TunisiaII

Good. Thanks for confirming.

However I still see occasional white lines on the mapboard when moving
the map around. This time I reproduced the error with right clicks to
recenter the map, it also occurs like that. Again, if after it occurs I
slightlyreposition the map with the up/down keys, the issue disappears.
This occurred at both 150% and 175%

I wasn’t expecting this to change with the most recent build, as I didn’t
work on this problem. My guess is that it’s due to a rounding error in
the board painter. Would you check whether this happens at 200%? (If I’m
right that the cause is a rounding error, I suspect you won’t see the
problem at 200% because 2 is an integer, whereas 1.5 and 1.75 are not.)


J.

Joel,
I tested at DPI scaling 200 as you suggested and also at scaling 201%
Indeed, the issue appeared at 201% but I did not see it at 200%

Joel, not sure if anyone reported this.
I spotted another thing that occurs with DPI scaling.
The TunisiaII module has the MapWindow Property - “Mouse_over Stack Viewer” with option “Display Text” active and a Summary text above the piece.

When the scaling is not 100% the text is displayed in an incorrect location. I suspect that scaling is not applied because the farther south and east I go on the map the farther away to the north west the text is displayed.

Kr
Claudio

One more issue.
Movement trail lines and ircles are not drawn if the scaling is 125%. They are for scaling 100%.

Hi,

Is there still time to add new features to the 3.3.0 release ?

Is there a plan to make an 3.3.1 ou 3.4 or you will stop here and work on 4.0 (i make to work the current source code and want to konw if there is a point to continu).

Regards,

Thus spake burzum51:

Hi,

Is there still time to add new features to the 3.3.0 release ?

I am reluctant to add new features to the current codebase, as new
features require testing, documentation, and ongoing support. Any
new feature at this point would have to be quite compelling for me
to consider its addition.

Is there a plan to make an 3.3.1 ou 3.4 or you will stop here and work
on 4.0 (i make to work the current source code and want to konw if there
is a point to continu).

My plan has long been and continues to be to shift to V4 when the
current release is out. There might be further 3.3.x releases to fix
bugs introduced in 3.3.0, but I don’t forsee doing more V3 series
releases otherwise.

If you would like to help, why not troubleshoot one of the bugs noted
on this thread? That’s the help we need right now.


J.

Thanks for you answer.

As this java version is obsolete and dead, i will not spend more time on it.

Thus spake burzum51:

Thanks for you answer.

As this java version is obsolete and dead, i will not spend more time on
it.

But it is not obsolete and dead. I’m working on 3.3.0 right now.

There are things with which I could use help, if you’d like to help, such
as finding the causes of the bugs reported on this thread. It may not be
the work you were wanting to do, but it’s the work which needs doing if
we’re going to move forward.


J.

3.3.0-svn9338 has adjustments for HiDPI support for images on buttons.

I made a test build for this particular problem: vassalengine.org/~uckelman/t … indows.exe

Does the repainting problem still happen with this build at non-integer system scale factors?

I’ve found the problem with the offset of the location indicator from the CounterDetailViewer. Expect a fix for that on Tuesday.

Hello Joel, I tested the proposed repaint fix at both 125% and 175%. I could not reproduce the issue, only once did I see a white line for less that 1 second and that went away by some repaint action.

Issues still occurring:
Location indicator (I see you have a solution)
Absence of Movement Trails (in both Tunisia II and The Longest Day)

Kr
Claudio

I’ve just uploaded 3.3.0-svn9342, which contains the repaint fix as well adjustments to CounterDetailViewer.

I’ll tackle movement trails next. Thank you for your persistence with testing builds.

All good with 9342. Only thing I found in Tunisia II is the Movement Trail. Will test other games later.

I found another HDPI Scaling issue. Maybe you are already aware of it:
In Vietnam 1965/1975 version 4.3.4 (vassalengine.org/mediawiki/i … 4.3.4.vmod)
You have a button that overlays s string of 1hex area of effects to mark a boundary. (You make them appear with the 2 buttons (red/blue squares) to the right of the 1D6 and 2D6 buttons.
At 100% these overlay appears in the correct manner. At 125% it appears somewhere else (at the 100% position I think).

I have an unpublished The Longest Day module that uses a similar technique. There too the issue appears.

The trait being used is “Area of Effect” vassalengine.org/wiki/AreaOfEffect

Kr
Claudio

The Vietnam module has 2 different uses of the Area of Effect trait. One is to highlight the hexes around some counters. That one works correctly at any scaling.
The differences I see is that while both are “Fixed Radius”, the one that fails has a radius of 0 (area only applies on origin hex).
econ
The other difference is that the one is set as “Always visible” (it is hidden when button pressed by a change in the Map Shading settings probably) whereas the one that works has “Always visible” unchecked.
Hope that helps.

3.3.0-svn9343 should fix the problem with Movement Trails.

3.3.0-svn9343 on MacBook Pro (with Retina) MacOS Catalina 10.15.4

Reporting against bugs that I logged earlier:

  • movement trails now working - tested on C&C Napoleonics 3.42

  • deck getting deleted in set up on C&C Napoleonics 3.42 - still a problem.

  • zoom bug when using the “saved map as PNG file” - still a problem

  • crashes in C&C Medieval - not re-tested.

Regards,

Mark

I ran the latest 3.3.0-svn9343 on my iMac 5K (Retina), screen set to Scaled resolution. The module shows correctly

Then I dragged this window over to my external FullHD (non-Retina) monitor. This image is at the same zoom level as the first image:

As you can see the board is clipped at the bottom, the first time I zoomed out from 100% to 44% to view the entire board the clipped part was black until I resized the panel to repaint it.

Not only is the image drawn at the wrong size, the position calculations are also all off. I can not click on anything as it’s not where it’s being drawn.