Test builds for 3.3.0

3.3.0-svn9343 on my iMac 5K (Retina), screen set to Scaled resolution.

Selection rectangle drawn is completely wrong. In this image I am dragging from the small cross (left top) to about where the big cross is (right bottom). The selection when I let go is correct, despite the rectangle visual.

Thus spake bdgza:

I ran the latest 3.3.0-svn9343 on my iMac 5K (Retina), screen set to
Scaled resolution. The module shows correctly

[1]

Then I dragged this window over to my external FullHD (non-Retina)
monitor. This image is at the same zoom level as the first image:

That’s new to me. I had no idea it was possible to have different OS
scale factors at once.

I’m not surprised this doesn’t work, as it’s not a situation I had
envisoned as something one could do. That’s a pretty significant
setback.


J.

Thus spake marktb1961:

  • zoom bug when using the “saved map as PNG file” - still a problem

3.3.0-svn9344 should fix this.


J.

The only silver lining I can provide is that macOS doesn’t allow window spanning across multiple displays at once. It’s either on the one (and clipped on the side), or on the other (and clipped on the opposite side). So a single window can’t be at multiple scale factors at once.

3.3.0-svn9344 macOS iMac 5K (Retina), screen scaled resolution.

Playing a game of Memoir '44 against myself, and when my ‘opponent’ moves on the other VASSAL client it draws a red outline of his moved unit in the wrong place on my VASSAL client. This only appears when the remote opponent has moved.

The (too small) red outline drawn on the river on the top left near the Pegasus Bridge is from my opponent moving a unit near the Orne river on the right:

The Windows client on the non-HiDPI display draws correctly when I move something on the Mac.

I messed with this module a bit in 3.2.17 and the most recent test build and wasn’t able to see what those buttons do. What are the steps for triggering this?

I might have found a solution to the problem of dragging between screens with different pixel scaling. (It occurred to me that there may also be a similar problem on systems where you can change the pixel scaling on the fly, which I guess is possible on Windows, and what I’m working on would solve that problem as well.)

What’s with the giant grey burritos east of Pegasus Bridge?

This ought to be good…Screen shot please!
On Friday, April 10, 2020, 10:35:04 AM CDT, uckelman uckelman@nomic.net wrote:

I might have found a solution to the problem of dragging between screens
with different pixel scaling. (It occurred to me that there may also be
a similar problem on systems where you can change the pixel scaling on
the fly, which I guess is possible on Windows, and what I’m working on
would solve that problem as well.)

What’s with the giant grey burritos east of Pegasus Bridge?


Read this topic online here:
https://forum.vassalengine.org/t/test-builds-for-3-3-0/10056/153

Rolls of barbed wire!

The giant grey burritos are rolls of barbed wire. The boardgame comes with pieces like this in green and blue to represent wire positions for each side. In the Memoir '44 Online game they are these grey ones.

Ha! This made me laugh. I needed a laugh.

I’ve uploaded a test build 3.3.0-svn9345-dynamic_scale: vassalengine.org/~uckelman/tmp/

This might solve the problem of dragging windows between screens with different scale factors, and also might give a correct result if you can change the scale factor on a screen while VASSAL is running.

3.3.0-svn9345 solves the scale factor problem, I can drag the window back and forth and it adjusts correctly. Selection on the map is also correct.

On the non-Retina display the drag rectangle is correct. On the Retina (scaled) display the drag rectangle is still drawn wrong.

Thus spake bdgza:

3.3.0-svn9345 solves the scale factor problem, I can drag the window
back and forth and it adjusts correctly. Selection on the map is also
correct.

Great. Thanks for testing.

The difference between this and the previous build is that the system
scale factor is fetched for each reapaint, so if it changes the next
repaint will pick that up.

On the non-Retina display the drag rectangle is correct. On the Retina
(scaled) display the drag rectangle is still drawn wrong.

I’ll look at this next.


J.

I think you opened a short scenario (like First Volley). These buttons only work with the Campaign scenario. Use the file I attach here to reproduce, it is a vlog of a campaing game. I managed to see the issue with that one.

Also, I have more information on the issue. It does not occur for all kinds of Area of Effects. I initially said it might be to a 0 radius, but looking again I found the same issue in The Longest Day (unpublished module) for a radius of 5. But what was common in both cases and not present in another area of effect in Vietnam is that the ones that cause the issue have the “Use Map Shading?” checkbox set. So the issue might be in how these “Map Shadings” handle the drawing of the shade vs how the Area of Effect without Map Shading do.

Kr
Claudio

Does 3.3.0-svn9346 fix the last moved highlighter for you?

This helped me find the problem, which was in MapShader.

Try 3.3.0-svn9347.

I’ve re-uploaded 3.3.0-svn9347. If you’re trying it after I posted this message, then it should also contain a fix for the selection rectangle.

Hello
The Area of Effect / Map Shading bug does not appear anymore in Vietnam. Thank you.
Kr
Claudio

I’ve now gone over RegionGrid and Region for HiDPI support. They didn’t require any changes.