Create account / Log in

Minor 3.5.5 bug: canceled Save As... reports as successful

Issues with the Vassal engine.

Moderators: uckelman, Tim M

Minor 3.5.5 bug: canceled Save As... reports as successful

Postby jrwatts » April 13th, 2021, 6:22 am

I just accidentally hit the "Save As..." button, instead of the "Save" button, after finishing some edits on my module. After cancelling the Save As dialog, the log told me "Module saved: xxxx.vmod", just as if I had actually hit the "Save" button, but I'm assuming it did not actually save anything (the Save As... menu option behaves the same).

Edit: On Linux (Kubuntu 20.10) with Java 11.0.10, if it makes any difference.
jrwatts
 
Posts: 309
Joined: April 29th, 2020, 10:30 pm

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby SMACarthur » April 13th, 2021, 1:44 pm

Do you use any antivirus?
SMACarthur
 
Posts: 3
Joined: March 23rd, 2021, 11:08 am

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby Cattlesquat » April 14th, 2021, 1:28 am

A test build of a fix is up -- the one labeled 14386 on the builds page - http://vassalengine.org/builds

If that solves the problems we'll try to release it with 3.5.6

Brian
User avatar
Cattlesquat
 
Posts: 1127
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby jrwatts » April 14th, 2021, 5:54 am

Just tried the test build, and it's not quite right--it no longer reports when I cancel the Save As..., but it also doesn't report after a successful Save (but it does after a successful Save As...).

Minor nit--the Linux archive was a .bz2 wrapped inside a .zip--seems a bit excessive!
jrwatts
 
Posts: 309
Joined: April 29th, 2020, 10:30 pm

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby uckelman » April 14th, 2021, 9:58 am

Thus spake jrwatts:
>
> Minor nit--the Linux archive was a .bz2 wrapped inside a .zip--seems a
> bit excessive!

GitHub Actions, which is what's running the builds, zips all artifacts.
I wish it wouldn't, but there's no way presently to tell it not to.

--
J.
User avatar
uckelman
Site Admin
 
Posts: 9354
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby uckelman » April 14th, 2021, 10:53 pm

Try VASSAL-3.5.6-SNAPSHOT-4d2d2e1: http://www.vassalengine.org/builds/

Does that fix the remaining problem?
User avatar
uckelman
Site Admin
 
Posts: 9354
Joined: December 10th, 2007, 9:48 am
Location: Durham, England

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby jrwatts » April 14th, 2021, 11:47 pm

Looks like it's fixed, yes.
jrwatts
 
Posts: 309
Joined: April 29th, 2020, 10:30 pm

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby marktb1961 » April 16th, 2021, 5:25 pm

In similar vein, I notice that Cancelling a scenario load, still gets the "Loaded" message even though the load is, as expected, cancelled.
e.g.

- Loading P414 - Grossbeeren.vsav ... <Load pre-set scenario was selected>
- Loaded P414 - Grossbeeren.vsav <Load cancelled at "Side" prompt but still this message appears>
Platform: Vassal 3.5.5, MacOS Big Sur on iMac (27", mid-2020)
User avatar
marktb1961
 
Posts: 581
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby Cattlesquat » April 18th, 2021, 3:17 pm

Ah, thanks for that. The new PR in snapshot 14401 should clear that bit up Mark.

Brian
User avatar
Cattlesquat
 
Posts: 1127
Joined: December 2nd, 2019, 4:57 pm
Location: Baltimore, Maryland, USA

Re: Minor 3.5.5 bug: canceled Save As... reports as successf

Postby marktb1961 » April 19th, 2021, 9:24 am

Tested cancelled load in VASSAL-3.5.6-SNAPSHOT-3a9a0b8... perfect:

- Loading B001 - Rolica1.vsav ...
- Load of B001 - Rolica1.vsav cancelled
User avatar
marktb1961
 
Posts: 581
Joined: October 4th, 2018, 2:36 pm
Location: Liverpool, England


Return to Technical Support & Bugs

Who is online

Users browsing this forum: No registered users and 5 guests